Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER_CHANGELOG.md has been added for v0.44.0 #1500

Closed
wants to merge 5 commits into from

Conversation

drganjoo
Copy link
Contributor

Motivation and Context

SERVER_CHANGELOG.md has been added (generated through the changelogger tool)

Description

Server side SDK has it's own SERVER_CHANGELOG.md that will have the server side changes carried out in a revision.

Testing

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@drganjoo drganjoo requested a review from a team as a code owner June 27, 2022 14:11
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti
Copy link
Collaborator

Let's talk about how we should go about this. My initial impression is that this shouldn't be a separate .next.toml since we can make changes that affect both the client and the server, and we shouldn't have to copy/paste entries into both files to represent those. Also, GitHub can only have one set of notes for a release, so these really should be combined.

I think we can just add a property to the current changelog toml format that indicates the change is for client, server, or both. Then we can just modify how we render the changelog so that it breaks out separate client/server sections.

@drganjoo
Copy link
Contributor Author

Let's talk about how we should go about this. My initial impression is that this shouldn't be a separate .next.toml since we can make changes that affect both the client and the server, and we shouldn't have to copy/paste entries into both files to represent those. Also, GitHub can only have one set of notes for a release, so these really should be combined.

I think we can just add a property to the current changelog toml format that indicates the change is for client, server, or both. Then we can just modify how we render the changelog so that it breaks out separate client/server sections.

Oh that would be great if we can have another field in meta tags to indicate whether the change is for client, server or both. Later on, if customers require that they should be able to view only server side changes, we can produce a separate .md file for them.

Thanks

- ⚠ ([smithy-rs#1424](https://github.com/awslabs/smithy-rs/issues/1424)) An error is raised if the http `Accept` header does not match the content type specified in smithy file

**New this release:**
- 🎉 ([smithy-rs#1454](https://github.com/awslabs/smithy-rs/issues/1454)) Python can be used for writing business logic, executing on top of smithy-rs Rust runtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not related to Python, I think you made a mistake linking it. It should be #1403

On top of this, the wording of the description is not 100% correct as until #1476 is not merged, the Python system is not usable.

I would reword it like: Initial support to code-generate support to write the business logic in Python, executing on top of Rust. This PR introduce code-generation of operations and simple shapes (Structure and Enum) and add runtime support to start the Hyper server from Python, but does not generate an importable shared library yet.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@crisidev
Copy link
Contributor

crisidev commented Aug 2, 2022

Is this PR still relevant?

@drganjoo drganjoo closed this Aug 2, 2022
@drganjoo drganjoo deleted the codegen-server-changelog branch August 2, 2022 20:41
@drganjoo
Copy link
Contributor Author

drganjoo commented Aug 2, 2022

This PR is no longer needed as changelog tool has now been updated to include server SDK changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants