Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now-unneeded protocol tests #1260

Closed
wants to merge 1 commit into from
Closed

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Mar 16, 2022

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from a team as a code owner March 16, 2022 16:28
@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Server Test

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 1.21% 79305.76 78357.67
Total requests 1.17% 7142095 7059817
Total errors NaN% 0 0
Total successes 1.17% 7142095 7059817
Average latency ms -1.28% 0.77 0.78
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -0.95% 24 24.23
Stdev latency ms 0.76% 1.33 1.32
Transfer Mb 1.17% 742.42 733.87
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@david-perez
Copy link
Contributor

Don't we first have to update Smithy version to use the fixed tests?

@rcoh
Copy link
Collaborator Author

rcoh commented Mar 21, 2022

Ah yeah I think you're right, I just saw the issues were closed on the smithy side

@jdisanti
Copy link
Collaborator

These were removed in #1330

@jdisanti jdisanti closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants