-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default list of http versions to request property bag #1258
Conversation
add: type alias for list of http versions add: decorator to add desired http versions to property bag fix: gradle warning for argument "model" update: CHANGELOG
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
...kotlin/software/amazon/smithy/rust/codegen/smithy/customizations/HttpVersionListGenerator.kt
Outdated
Show resolved
Hide resolved
rename: HttpVersionListGenerator.kt to HttpVersionListCustomization.kt update: HttpVersionListCustomization to grab versions from models when possible fix: various docs issues reported by IDE add: new "Extras" section to ServiceConfig update: code broke by "Extras" change add: tests for http version sniffing
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Motivation and Context
#1257
Description
This PR adds a list of HTTP versions to the request property bag. In a future update, this list will, in part, be used to determine what client to use when making HTTP requests and will be configurable on a per-request basis.
Testing
ran existing tests and added new tests for the HTTP version sniffing
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.