Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default list of http versions to request property bag #1258

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Mar 15, 2022

Motivation and Context

#1257

Description

This PR adds a list of HTTP versions to the request property bag. In a future update, this list will, in part, be used to determine what client to use when making HTTP requests and will be configurable on a per-request basis.

Testing

ran existing tests and added new tests for the HTTP version sniffing

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

add: type alias for list of http versions
add: decorator to add desired http versions to property bag
fix: gradle warning for argument "model"
update: CHANGELOG
@Velfi Velfi requested a review from a team as a code owner March 15, 2022 15:44
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -3.69% 71818.41 74569.32
Total requests -3.77% 6464267 6717394
Total errors NaN% 0 0
Total successes -3.77% 6464267 6717394
Average latency ms -21.65% 0.76 0.97
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 5.46% 21.63 20.51
Stdev latency ms -23.93% 1.24 1.63
Transfer Mb -3.77% 671.96 698.28
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 0.28% 76398 76182.75
Total requests 0.29% 6883286 6863714
Total errors NaN% 0 0
Total successes 0.29% 6883286 6863714
Average latency ms -23.20% 0.96 1.25
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -1.92% 23.47 23.93
Stdev latency ms -21.50% 1.68 2.14
Transfer Mb 0.28% 715.52 713.49
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Velfi added 2 commits March 16, 2022 15:38
rename: HttpVersionListGenerator.kt to HttpVersionListCustomization.kt
update: HttpVersionListCustomization to grab versions from models when possible
fix: various docs issues reported by IDE
add: new "Extras" section to ServiceConfig
update: code broke by "Extras" change
add: tests for http version sniffing
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 0.95% 78026.67 77289.77
Total requests 0.95% 7027485 6961567
Total errors NaN% 0 0
Total successes 0.95% 7027485 6961567
Average latency ms 2.34% 1.31 1.28
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 4.18% 27.19 26.1
Stdev latency ms 0.00% 2.21 2.21
Transfer Mb 0.95% 730.51 723.66
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 3.35% 72363.53 70020.05
Total requests 3.38% 6517642 6304476
Total errors NaN% 0 0
Total successes 3.38% 6517642 6304476
Average latency ms 0.83% 1.21 1.2
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 3.15% 24.53 23.78
Stdev latency ms -0.49% 2.02 2.03
Transfer Mb 3.38% 677.51 655.35
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@Velfi Velfi merged commit 3eaddcf into main Mar 17, 2022
@Velfi Velfi deleted the add/default_desired_http_version_to_property_bag branch March 17, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants