-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify a read buffer initial capacity when creating ByteStream from a file #1238
Merged
rcoh
merged 19 commits into
smithy-lang:main
from
tanguylebarzic:tanguy.lebarzic/file-reader-capacity
Apr 21, 2022
+264
−33
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f45d757
Allow to specify a read buffer initial capacity when creating ByteStr…
tanguylebarzic 0a216e3
Rename len to file_size
tanguylebarzic e81119a
Use a builder to specify advanced options to create a ByteStream
tanguylebarzic 85683d1
Improved comments
tanguylebarzic b38a34a
Specify the unit to use for PathBodyBuilder.with_file_size
tanguylebarzic 33a5e62
Improved comments following review
tanguylebarzic 6b94368
Rename PathBodyBuilder to FsBuilder
tanguylebarzic 401f0b0
Renaming in FsBuilder
tanguylebarzic e0b6650
Make PathBody private
tanguylebarzic f13845c
Updated API for FsBuilder
tanguylebarzic cb564b5
Document panic behavior of ByteStream::build
tanguylebarzic 304f555
Document ByteStream::read_from
tanguylebarzic 51e271d
Move ByteStream::read_from
tanguylebarzic 67986d9
Update rust-runtime/aws-smithy-http/src/byte_stream.rs
rcoh d9c3d02
Merge branch 'main' into tanguy.lebarzic/file-reader-capacity
rcoh cefb37e
Merge branch 'main' into tanguy.lebarzic/file-reader-capacity
rcoh 7e68316
Fix clippy errors
rcoh 22b98fe
Merge branch 'main' into tanguy.lebarzic/file-reader-capacity
rcoh 8171699
Merge branch 'main' into tanguy.lebarzic/file-reader-capacity
rcoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Specify the unit to use for PathBodyBuilder.with_file_size
commit b38a34ad15b85d7fccbf8cd15c6e41bac93e39f2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.