-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Smithy to 1.16.1 #1053
Merged
+462
−108
Merged
Upgrade Smithy to 1.16.1 #1053
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d8b33c9
Upgrade Smithy to 1.16.1
jdisanti 50b469e
Update changelog
jdisanti 41a721b
Merge remote-tracking branch 'upstream/main' into jdisanti-upgrade-to…
jdisanti 98bf201
Fix ktlint
jdisanti d8712e6
Fix clippy
jdisanti 02df022
Fix header quoting issues
jdisanti d5b30de
Add fuzz test for `read_many_from_str`
jdisanti be45634
Merge remote-tracking branch 'upstream/main' into jdisanti-upgrade-to…
jdisanti d9f55cf
Fix codegen integration tests
jdisanti ad08f55
Incorporate feedback
jdisanti 230b37c
Merge remote-tracking branch 'upstream/main' into jdisanti-upgrade-to…
jdisanti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
target | ||
corpus | ||
artifacts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
[package] | ||
name = "aws-smithy-http-fuzz" | ||
version = "0.0.0" | ||
authors = ["Automatically generated"] | ||
publish = false | ||
edition = "2018" | ||
|
||
[package.metadata] | ||
cargo-fuzz = true | ||
|
||
[dependencies] | ||
libfuzzer-sys = "0.4" | ||
http = "0.2.3" | ||
|
||
[dependencies.aws-smithy-http] | ||
path = ".." | ||
|
||
# Prevent this from interfering with workspaces | ||
[workspace] | ||
members = ["."] | ||
|
||
[[bin]] | ||
name = "read_many_from_str" | ||
path = "fuzz_targets/read_many_from_str.rs" | ||
test = false | ||
doc = false |
14 changes: 14 additions & 0 deletions
14
rust-runtime/aws-smithy-http/fuzz/fuzz_targets/read_many_from_str.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#![no_main] | ||
use libfuzzer_sys::fuzz_target; | ||
|
||
use aws_smithy_http::header::read_many_from_str; | ||
use http; | ||
|
||
fuzz_target!(|data: &[u8]| { | ||
if let Ok(s) = std::str::from_utf8(data) { | ||
if let Ok(req) = http::Request::builder().header("test", s).body(()) { | ||
// Shoudln't panic | ||
let _ = read_many_from_str::<String>(req.headers().get_all("test").iter()); | ||
} | ||
} | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this ever return OK? you can make a request without a URI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the builder builds successfully. I verified by adding a
panic!
inside of the conditions, and it definitely gets triggered.