Add client-support for RPC v2 CBOR #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jul 18, 2024
...otlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/parse/CborParserGenerator.kt
Outdated
Show resolved
Hide resolved
Velfi
approved these changes
Jul 18, 2024
david-perez
requested changes
Jul 19, 2024
.../main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/ErrorCorrection.kt
Show resolved
Hide resolved
.../amazon/smithy/rust/codegen/client/smithy/generators/protocol/ClientProtocolTestGenerator.kt
Show resolved
Hide resolved
...e/amazon/smithy/rust/codegen/client/smithy/generators/protocol/RequestSerializerGenerator.kt
Show resolved
Hide resolved
...-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/RpcV2Cbor.kt
Outdated
Show resolved
Hide resolved
This commit addresses: #3767 (comment) #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses the following: #3767 (comment) #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment) #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Jul 31, 2024
.../main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/ErrorCorrection.kt
Show resolved
Hide resolved
...-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/RpcV2Cbor.kt
Outdated
Show resolved
Hide resolved
...otlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/parse/CborParserGenerator.kt
Outdated
Show resolved
Hide resolved
.../amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt
Show resolved
Hide resolved
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
This commit addresses #3767 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow-up on #2544 to add client-side support for the protocol
Description
The client implementation mainly focuses on a sub-section Requests in the spec. To that end, this PR addresses
TODOfor the client to fill in the blanks and includes additional adjustments/refactoring to pass client protocol tests.Testing
rpcv2Cborrpcv2Cbor-extras.smithyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.