Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints 2.0 - Add ResolveEndpointAsync Add blanket implementation for ResolveEndpoint #2608

Closed
rcoh opened this issue Apr 20, 2023 · 1 comment
Closed

Endpoints 2.0 - Add ResolveEndpointAsync Add blanket implementation for ResolveEndpoint #2608

rcoh opened this issue Apr 20, 2023 · 1 comment
Assignees
@rcoh
Labels
breaking-change This will require a breaking change breaking-nominated-q2 Breaking changes slated for q2-2023 release

Comments

@rcoh
Copy link
Collaborator

rcoh commented Apr 20, 2023

(Keep endpoint implementations trivial when they don’t need to be async)
@rcoh rcoh self-assigned this Apr 20, 2023
@rcoh rcoh added breaking-change This will require a breaking change breaking-nominated-q2 Breaking changes slated for q2-2023 release labels Apr 20, 2023
@rcoh rcoh mentioned this issue Jun 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2023
@rcoh
Make endpoint resolution async (#2816)
ee5aadc 
## Motivation and Context
Make endpoint resolution async from the perspective of the orchestrator.
- #2608 

## Description
Change the endpoint trait in the orchestrator to be asynchronous

## Testing
- compiled code

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@rcoh
Copy link
Collaborator Author

rcoh commented Oct 18, 2023

Fixed in #3078

@rcoh rcoh closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcoh rcoh

Labels
breaking-change This will require a breaking change breaking-nominated-q2 Breaking changes slated for q2-2023 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcoh