Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client re-exports #1759

Closed
22 tasks done
jdisanti opened this issue Sep 21, 2022 · 0 comments
Closed
22 tasks done

Client re-exports #1759

jdisanti opened this issue Sep 21, 2022 · 0 comments
Assignees
@ysaito1001
Labels
client sdk-ga tracking Meta-issues to track overall progress
Milestone
SDK GA

Comments

@jdisanti
Copy link
Collaborator

jdisanti commented Sep 21, 2022 •
edited by ysaito1001
Loading

The following types should get re-exported by generated client crates, ones denoted as (*) in both the Previous Organization and the New Organization section in RFC: Client Crate Organization:

The way we re-export types varies depending upon which client crate organization scheme is employed but we need to ensure that re-exports should be supported in both schemes.

Previous Organization

  • client
    • Builder
  • config
    • retry::{RetryConfig, RetryConfigBuilder, RetryMode}
    • timeout::{TimeoutConfig, TimeoutConfigBuilder}
    • AsyncSleep, Sleep
  • operation
    • customize::{ClassifyRetry, Operation, Request, Response, RetryKind}
  • types
    • AggregatedBytes, ByteStream, SdkBody, SdkError, DisplayErrorContext, ProvideErrorMetadata, Blob, DateTime,
  • AppName, Credentials, Endpoint, Region, Error, Config, Client

New Organization

  • client
    • customize::{ClassifyRetry, Operation, Request, Response, RetryKind}
    • Builder (only in non-SDK crates)
  • config
    • retry::{RetryConfig, RetryConfigBuilder, RetryMode}
    • timeout::{TimeoutConfig, TimeoutConfigBuilder}
    • AppName, AsyncSleep, Credentials, Endpoint, Region, Sleep
  • error
    • DisplayErrorContext, SdkError, ProvideErrorMetadata
  • primitives
    • AggregatedBytes, Blob, ByteStream, DateTime, SdkBody
@jdisanti jdisanti added the tracking Meta-issues to track overall progress label Sep 21, 2022
@jdisanti jdisanti added this to the SDK GA milestone Sep 21, 2022
This was referenced Sep 30, 2022
Closed
Closed
@andresrsanchez andresrsanchez mentioned this issue Nov 14, 2022
Merged
SomeoneToIgnore pushed a commit to neondatabase/neon that referenced this issue Nov 16, 2022
@andresrsanchez
Introduce aws-sdk-rust as rusoto S3 replacement (#2802)
c4b417e 
- `aws-smithy-http`: Needed because of `SdkBody` see
smithy-lang/smithy-rs#1759
- `aws-types`: Needed because of `SharedCredentialsProvider`, the
recommended way from aws is something like
`aws_config::from_env().region("us-east-1").load().await` but that is
problematic because of:

- `sync -> async ` in the creation of S3Client and i don't want to
change the signature of any method in this class.
- We do not need the four default steps in
https://github.com/awslabs/aws-sdk-rust/blob/main/sdk/aws-config/src/default_provider/credentials.rs#L235

- `Hyper`: Similar to what's currently doing Rusoto in
https://github.com/rusoto/rusoto/blob/master/rusoto/signature/src/signature.rs#L59
to stream the body, see also
awslabs/aws-sdk-rust#361

Co-authored-by: andres <[email protected]>
ysaito1001 added a commit that referenced this issue Mar 7, 2023
@ysaito1001
Add more client re-exports
56c37b1 
This commit adds more client re-exports proposed in
#1759.
Specifically, it re-exports the following types:
- `aws_smithy_http::body::SdkBody`
- `aws_smithy_http::byte_stream::error::Error`
- `aws_smithy_http::operation::{Request, Response}`
@ysaito1001 ysaito1001 mentioned this issue Mar 7, 2023
Merged
3 tasks
ysaito1001 added a commit that referenced this issue Mar 9, 2023
@ysaito1001
Add more client re-exports (#2437)
7f4152c 
* Add more client re-exports

This commit adds more client re-exports proposed in
#1759.
Specifically, it re-exports the following types:
- `aws_smithy_http::body::SdkBody`
- `aws_smithy_http::byte_stream::error::Error`
- `aws_smithy_http::operation::{Request, Response}`

* Update CHANGELOG.next.toml

---------

Co-authored-by: Yuki Saito <[email protected]>
rcoh pushed a commit to awslabs/aws-sdk-rust that referenced this issue Mar 28, 2023
@ysaito1001 @aws-sdk-rust-ci
[smithy-rs] Add more client re-exports (#2437)
b51c86c 
* Add more client re-exports

This commit adds more client re-exports proposed in
smithy-lang/smithy-rs#1759.
Specifically, it re-exports the following types:
- `aws_smithy_http::body::SdkBody`
- `aws_smithy_http::byte_stream::error::Error`
- `aws_smithy_http::operation::{Request, Response}`

* Update CHANGELOG.next.toml

---------

Co-authored-by: Yuki Saito <[email protected]>
aws-sdk-rust-ci pushed a commit to awslabs/aws-sdk-rust that referenced this issue Mar 30, 2023
@ysaito1001 @aws-sdk-rust-ci
[smithy-rs] Add more client re-exports (#2437)
58c378d 
* Add more client re-exports

This commit adds more client re-exports proposed in
smithy-lang/smithy-rs#1759.
Specifically, it re-exports the following types:
- `aws_smithy_http::body::SdkBody`
- `aws_smithy_http::byte_stream::error::Error`
- `aws_smithy_http::operation::{Request, Response}`

* Update CHANGELOG.next.toml

---------

Co-authored-by: Yuki Saito <[email protected]>
@rcoh rcoh closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysaito1001 ysaito1001

Labels
client sdk-ga tracking Meta-issues to track overall progress
Projects
None yet
Milestone
SDK GA
Development

No branches or pull requests
3 participants
@jdisanti @rcoh @ysaito1001