Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-smithy-http-tower: Lower log level of two info logs. #1735

Merged

Conversation

vojtechkral
Copy link
Contributor

@vojtechkral vojtechkral commented Sep 15, 2022

Motivation and Context

aws-smithy-http-tower polutes our logs with info-level messages.

Description

Changed two info-level messages to debug level, it felt appropriate...

Testing

I wanted to run ./gradlew rust-runtime:cargoTest but I got the following error:

Task 'cargoTest' not found in project ':rust-runtime'.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vojtechkral vojtechkral requested a review from a team as a code owner September 15, 2022 13:05
@jdisanti
Copy link
Collaborator

Just so I understand this better, are you logging span open/close events? I don't think these emit normally.

@vojtechkral
Copy link
Contributor Author

Just so I understand this better, are you logging span open/close events? I don't think these emit normally.

No explicit configuration that I know of. We're seeing these in logs:

 2022-09-15T12:23:58.270Z INFO  aws_smithy_http_tower::parse_response > send_operation; status="ok"
 2022-09-15T12:23:58.280Z INFO  aws_smithy_http_tower::parse_response > send_operation;
 2022-09-15T12:23:58.280Z INFO  aws_smithy_http_tower::parse_response > send_operation; operation="ListObjectsV2"
 2022-09-15T12:23:58.280Z INFO  aws_smithy_http_tower::parse_response > send_operation; service="s3"
 2022-09-15T12:23:58.281Z INFO  aws_smithy_http_tower::parse_response > send_operation;
 2022-09-15T12:23:58.281Z INFO  aws_smithy_http_tower::parse_response > send_operation; operation="ListObjectsV2"
 2022-09-15T12:23:58.281Z INFO  aws_smithy_http_tower::parse_response > send_operation; service="s3"
 2022-09-15T12:23:58.281Z INFO  aws_smithy_http_tower::parse_response > send_operation;
 2022-09-15T12:23:58.281Z INFO  aws_smithy_http_tower::parse_response > send_operation; operation="ListObjectsV2"
 2022-09-15T12:23:58.281Z INFO  aws_smithy_http_tower::parse_response > send_operation; service="s3"

@jdisanti jdisanti enabled auto-merge (squash) September 19, 2022 17:12
@jdisanti jdisanti merged commit b02f9ad into smithy-lang:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants