Change detailed logs in CredentialsProviderChain from info to debug #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velfi
approved these changes
Jul 26, 2022
We usually use tada (:tada:) for new features or things that a lot of people have been asking for. If you don't think this fits any of tada/bug/breaking, then you can just have all three be |
lkts
force-pushed
the
relax-credentials-chain-logs
branch
from
37f9368
to
2105e2f
Compare
* Update RFC links Some links in https://awslabs.github.io/smithy-rs/design/rfcs/overview.html are broken. Signed-off-by: Daniele Ahmed <[email protected]>
lkts
force-pushed
the
relax-credentials-chain-logs
branch
from
2105e2f
to
9cacbd3
Compare
|
I haven't used GitHub in a while and i don't know how to deal with two commits that are from Update: it seems fine now |
jdisanti
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Those logs are written quite often and in current state there can be ~ 4 log lines for each credential retrieval operation: three for providers that didn't provide credentials and one final for provider that does.
Given that some providers in chain not providing credentials is an expected situation, having those logs on INFO level is quite noisy.
Description
This change changes level of commonly written logs from info to debug.
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.