Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Smithy #1330

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Upgrade Smithy #1330

merged 11 commits into from
Apr 21, 2022

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Apr 19, 2022

Motivation and Context

This PR updates to the latest Smithy release.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 15.15% 86502.85 75119.03
Total requests 15.11% 7786858 6764526
Total errors NaN% 0 0
Total successes 15.11% 7786858 6764526
Average latency ms -2.00% 0.98 1
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 21.25% 27.16 22.4
Stdev latency ms 6.43% 1.82 1.71
Transfer Mb 15.11% 809.45 703.18
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -1.70% 72012.82 73255.85
Total requests -1.73% 6481976 6596329
Total errors NaN% 0 0
Total successes -1.73% 6481976 6596329
Average latency ms -5.74% 1.15 1.22
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -9.92% 21.34 23.69
Stdev latency ms -7.28% 1.91 2.06
Transfer Mb -1.73% 673.8 685.69
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -1.73% 77717.79 79089.3
Total requests -1.79% 6997745 7125012
Total errors NaN% 0 0
Total successes -1.79% 6997745 7125012
Average latency ms -10.66% 1.09 1.22
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -1.39% 24.05 24.39
Stdev latency ms -8.92% 1.94 2.13
Transfer Mb -1.79% 727.42 740.65
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -1.62% 83985.94 85372.49
Total requests -1.71% 7559002 7690378
Total errors NaN% 0 0
Total successes -1.71% 7559002 7690378
Average latency ms -9.45% 1.15 1.27
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 40.34% 33.71 24.02
Stdev latency ms -5.80% 2.11 2.24
Transfer Mb -1.71% 785.76 799.42
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 0.45% 86143.62 85759.43
Total requests 0.51% 7760020 7720852
Total errors NaN% 0 0
Total successes 0.51% 7760020 7720852
Average latency ms -7.09% 1.18 1.27
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 16.07% 27.81 23.96
Stdev latency ms -3.59% 2.15 2.23
Transfer Mb 0.51% 806.66 802.59
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -21.62% 55608.27 70942.79
Total requests -21.68% 5004913 6390715
Total errors NaN% 0 0
Total successes -21.68% 5004913 6390715
Average latency ms -38.54% 0.59 0.96
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 13.34% 24.05 21.22
Stdev latency ms -73.72% 0.41 1.56
Transfer Mb -21.69% 520.26 664.32
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -3.79% 74573.7 77511.76
Total requests -3.78% 6718141 6982335
Total errors NaN% 0 0
Total successes -3.78% 6718141 6982335
Average latency ms -14.71% 0.58 0.68
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 6.22% 21.35 20.1
Stdev latency ms -18.75% 0.91 1.12
Transfer Mb -3.78% 698.35 725.82
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@jdisanti jdisanti marked this pull request as ready for review April 20, 2022 19:00
@jdisanti jdisanti requested review from a team as code owners April 20, 2022 19:00
@rcoh rcoh requested a review from david-perez April 20, 2022 19:06
Copy link
Contributor

@david-perez david-perez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The new server protocol test failures are indeed still things we don't handle correctly.

@rcoh rcoh merged commit 27acbc6 into main Apr 21, 2022
@rcoh rcoh deleted the jdisanti-upgrade-smithy branch April 21, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants