Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aws_smithy_types::primitive::Parse to parse URI path labels and query strings as primitive types in the server #1232

Closed
david-perez opened this issue Mar 2, 2022 · 0 comments · Fixed by #2528
Closed

Use aws_smithy_types::primitive::Parse to parse URI path labels and query strings as primitive types in the server #1232

david-perez opened this issue Mar 2, 2022 · 0 comments · Fixed by #2528
Assignees
@drganjoo
Labels
good first issue Good for newcomers server Rust server SDK

Comments

@david-perez
Copy link
Contributor

The aws_smithy_types crate conveniently exposes the aws_smithy_types::primitive::Parse trait implemented by some types to parse "Smithy primitives".

However, we're not using it in the server implementation to parse URI path labels and query string key-value pairs. We're instead generating this:

https://github.com/awslabs/smithy-rs/blob/f34abdaf2c3a8fb0c160778f36911efb457f9a18/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/protocols/ServerHttpProtocolGenerator.kt#L1018-L1036
@david-perez david-perez added the server Rust server SDK label Mar 2, 2022
@david-perez david-perez added the good first issue Good for newcomers label May 26, 2022
@drganjoo drganjoo self-assigned this Jul 28, 2022
david-perez added a commit that referenced this issue Apr 3, 2023
@david-perez
Use aws_smithy_types::primitive::Parse in the server
72750b7 
This further reduces the number of request rejection variants.
https://docs.rs/aws-smithy-types/latest/aws_smithy_types/primitive/trait.Parse.html

Closes #1232.
@david-perez david-perez mentioned this issue Apr 3, 2023
Merged
david-perez added a commit that referenced this issue Apr 3, 2023
@david-perez
Use aws_smithy_types::primitive::Parse in the server
dbea286 
This further reduces the number of request rejection variants.
https://docs.rs/aws-smithy-types/latest/aws_smithy_types/primitive/trait.Parse.html

Closes #1232.
david-perez added a commit that referenced this issue Apr 3, 2023
@david-perez
Use aws_smithy_types::primitive::Parse in the server
433b377 
This further reduces the number of request rejection variants.
https://docs.rs/aws-smithy-types/latest/aws_smithy_types/primitive/trait.Parse.html

Closes #1232.
unexge pushed a commit that referenced this issue Apr 24, 2023
@david-perez @unexge
Use aws_smithy_types::primitive::Parse in the server (#2528)
896a29a 
This further reduces the number of request rejection variants.
https://docs.rs/aws-smithy-types/latest/aws_smithy_types/primitive/trait.Parse.html

Closes #1232.
rcoh pushed a commit that referenced this issue Apr 24, 2023
@david-perez @rcoh
Use aws_smithy_types::primitive::Parse in the server (#2528)
dce3336 
This further reduces the number of request rejection variants.
https://docs.rs/aws-smithy-types/latest/aws_smithy_types/primitive/trait.Parse.html

Closes #1232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drganjoo drganjoo

Labels
good first issue Good for newcomers server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use aws_smithy_types::primitive::Parse in the server smithy-lang/smithy-rs
2 participants
@david-perez @drganjoo