Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResponseExtensions to _all_ server responses #1063

Closed
david-perez opened this issue Jan 12, 2022 · 0 comments · Fixed by #1072
Closed

Add ResponseExtensions to _all_ server responses #1063

david-perez opened this issue Jan 12, 2022 · 0 comments · Fixed by #1072
Labels
bug Something isn't working server Rust server SDK

Comments

@david-perez
Copy link
Contributor

We're only adding RequestExtensions to responses of fallible operations.

We should also rename the struct to ResponseExtensions, since we only add them to responses, not requests.
@david-perez david-perez added the server Rust server SDK label Jan 12, 2022
@crisidev crisidev added the bug Something isn't working label Jan 12, 2022
@david-perez david-perez mentioned this issue Jan 12, 2022
Merged
1 task
david-perez added a commit that referenced this issue Jan 13, 2022
@david-perez
rust-server-codegen: add ResponseExtensions to non-fallible opera…
ec9515d 
…tions

This commit also renames `RequestExtensions` to `ResponseExtensions`,
since we add this extension type only to HTTP responses. It also makes
its members private.

Closes #1063.
@david-perez david-perez mentioned this issue Jan 13, 2022
Merged
david-perez added a commit that referenced this issue Jan 28, 2022
@david-perez
rust-server-codegen: add ResponseExtensions to non-fallible opera…
4ae272b 
…tions

This commit also renames `RequestExtensions` to `ResponseExtensions`,
since we add this extension type only to HTTP responses. It also makes
its members private.

Closes #1063.
david-perez added a commit that referenced this issue Jan 28, 2022
@david-perez
rust-server-codegen: add ResponseExtensions to non-fallible opera…
d48c234 
…tions (#1072)

`rust-server-codegen`: add `ResponseExtensions` to non-fallible operations

This commit also renames `RequestExtensions` to `ResponseExtensions`,
since we add this extension type only to HTTP responses. It also makes
its members private.

Closes #1063.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rust-server-codegen: add ResponseExtensions to non-fallible operations smithy-lang/smithy-rs
2 participants
@crisidev @david-perez