Skip to content

Commit

Permalink
Separate check-sdk-examples step and remove it from release checks (#…
Browse files Browse the repository at this point in the history
…2088)

* Run examples based on flag

* Specify input in ci.yml

* Try to make ci.yml valid

* Add input description

* Put inputs under workflow_call

* Add type boolean
  • Loading branch information
jjant authored Dec 12, 2022
1 parent adf98a3 commit c3de8a3
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,5 @@ jobs:
ci:
needs: rebuild-docker-build-image
uses: ./.github/workflows/ci.yml
with:
run_sdk_examples: true
2 changes: 2 additions & 0 deletions .github/workflows/ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:
ci:
needs: acquire-base-image
uses: ./.github/workflows/ci.yml
with:
run_sdk_examples: true

# The PR bot requires a Docker build image, so make it depend on the `acquire-base-image` job.
pr_bot:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,15 @@
# on if a pull request is being checked, or if the `main` branch is being checked after merge.

name: Test

on:
workflow_call:
inputs:
run_sdk_examples:
description: Whether to run the SDK example checks or not.
required: false
default: false
type: boolean

env:
rust_version: 1.62.1
Expand Down Expand Up @@ -244,6 +251,7 @@ jobs:
# This job is split out from the rest since it is not required to pass for merge
check-sdk-examples:
name: Check SDK Examples
if: ${{ inputs.run_sdk_examples == 'true' }}
needs: generate
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ jobs:
needs:
- acquire-base-image
uses: ./.github/workflows/ci.yml
with:
run_sdk_examples: false

release:
name: Release
Expand Down

0 comments on commit c3de8a3

Please sign in to comment.