Skip to content

Commit

Permalink
Fix request ID logging for streaming operations (#2495)
Browse files Browse the repository at this point in the history
  • Loading branch information
jdisanti authored Mar 27, 2023
1 parent c76e73a commit b65a645
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.next.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,15 @@ message = "The outputs for event stream operations now implement the `Sync` auto
references = ["smithy-rs#2496"]
meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "all"}
author = "jdisanti"

[[aws-sdk-rust]]
message = "Streaming operations now emit the request ID at the `debug` log level like their non-streaming counterparts."
references = ["smithy-rs#2495"]
meta = { "breaking" = false, "tada" = false, "bug" = true }
author = "jdisanti"

[[smithy-rs]]
message = "Streaming operations now emit the request ID at the `debug` log level like their non-streaming counterparts."
references = ["smithy-rs#2495"]
meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "client"}
author = "jdisanti"
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class HttpBoundProtocolTraitImplGenerator(
impl #{ParseResponse} for $operationName {
type Output = std::result::Result<#{O}, #{E}>;
fn parse_unloaded(&self, response: &mut #{operation}::Response) -> Option<Self::Output> {
#{BeforeParseResponse}
// This is an error, defer to the non-streaming parser
if !response.http().status().is_success() && response.http().status().as_u16() != $successCode {
return None;
Expand All @@ -161,6 +162,9 @@ class HttpBoundProtocolTraitImplGenerator(
"E" to symbolProvider.symbolForOperationError(operationShape),
"parse_streaming_response" to parseStreamingResponse(operationShape, customizations),
"parse_error" to parseError(operationShape, customizations),
"BeforeParseResponse" to writable {
writeCustomizations(customizations, OperationSection.BeforeParseResponse(customizations, "response"))
},
*codegenScope,
)
}
Expand Down

0 comments on commit b65a645

Please sign in to comment.