Add const to generated enum values() (#2011)

* Add const to generated enum values() Enum values() functions return static arrays of static strings and could be of compile time use. Make callable in const contexts. * Add reference to PR in changelog next for const enum values() * Correct changelog next target to all for const enum values() Co-authored-by: Luca Palmieri <[email protected]>
smithy-lang · Nov 22, 2022 · 0f26ead · 0f26ead
1 parent 86fd8f5
commit 0f26ead
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml
@@ -478,3 +478,9 @@ x-amzn-errortype: com.example.service#InvalidRequestException
 references = ["smithy-rs#1982"]
 meta = { "breaking" = true, "tada" = false, "bug" = false, "target" = "server" }
 author = "david-perez"
+
+[[smithy-rs]]
+message = "Make generated enum `values()` functions callable in const contexts."
+references = ["smithy-rs#2011"]
+meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "all" }
+author = "lsr0"
diff --git a/...c/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/EnumGenerator.kt b/...c/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/EnumGenerator.kt
@@ -141,7 +141,7 @@ open class EnumGenerator(
             }
 
             docs("Returns all the `&str` representations of the enum members.")
-            rustBlock("pub fn $Values() -> &'static [&'static str]") {
+            rustBlock("pub const fn $Values() -> &'static [&'static str]") {
                 withBlock("&[", "]") {
                     val memberList = sortedMembers.joinToString(", ") { it.value.dq() }
                     rust(memberList)
@@ -198,7 +198,7 @@ open class EnumGenerator(
             }
 
             rust("/// Returns all the `&str` values of the enum members.")
-            rustBlock("pub fn $Values() -> &'static [&'static str]") {
+            rustBlock("pub const fn $Values() -> &'static [&'static str]") {
                 withBlock("&[", "]") {
                     val memberList = sortedMembers.joinToString(", ") { it.value.doubleQuote() }
                     write(memberList)