fix: x-amz-content-sha256 header is expected for unsigned payload and event stream operations #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event stream operations
|
Kudos, SonarCloud Quality Gate passed!
|
lauzadis
approved these changes
Aug 23, 2023
ianbotsf
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
fixes awslabs/aws-sdk-kotlin#1029
Description of changes
SignedBodyHeaderexecution context attribute when the operation has the unsigned payload trait or is an event stream input. When set the signer will add thex-amz-content-sha256header to the canonical request and set the header.shouldSignHeaderpredicate to theAwsHttpSigner.Config. This was missing and allows auth scheme overrides to augment the set of signed headers. This allowed me to narrow down the issue since we include a few more headers than AWS CLI did. This should have been possible previously and I was surprised it wasn't.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.