Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: reorder events in HttpEngineEventListener #919

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

ianbotsf
Copy link
Contributor

Issue #

(none)

Description of changes

As suggested by Matas, this PR reorders the event handlers in HttpEngineEventListener to align with the OkHttp documentation and generally be in order of sequential execution.

There are no functional changes in this PR, just reordering methods.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Aug 14, 2023
@ianbotsf ianbotsf requested a review from a team as a code owner August 14, 2023 20:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@lauzadis lauzadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ianbotsf ianbotsf self-assigned this Aug 14, 2023
@ianbotsf ianbotsf merged commit ab4ad2d into main Aug 15, 2023
@ianbotsf ianbotsf deleted the misc-reorder-okhttp-events branch August 15, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants