Incorrect "http.nonProxyHosts" property name

[grassehh]

Describe the bug

Configuring the http.nonProxyHosts system property is not working.

Expected Behavior

As explained in the documentation the property http.nonProxyHosts should be used to determine non proxy hosts.

Current Behavior

Setting http.nonProxyHosts system property has no effect because http.noProxyHosts is used instead.

Steps to Reproduce

Simply configure a client using environment while having defined http.nonProxyHosts system property. For example:

S3Client.fromEnvironment {}

Then if you make a request to a host defined in the system property, the http client will still try to go through the proxy.

Possible Solution

Replace http.noProxyHosts with http.nonProxyHosts at this line : (

smithy-kotlin/runtime/protocol/http-client/common/src/aws/smithy/kotlin/runtime/http/engine/EnvironmentProxySelector.kt

Line 131 in 2c138ed

val noProxyHostProps = provider.getProperty("http.noProxyHosts")

)

Context

We were trying to configure the proxy of an S3 client only by using the Java System properties.

Your Environment

• Smithy Kotlin version used: 1.0.11
• Platform (JVM/JS/Native): JVM (Java 21)
• Operating System and version: Debian 12

[lauzadis]

Thanks for the bug report! You're right, we should be checking http.nonProxyHosts instead of http.noProxyHosts as the Java specification states.

To maintain backwards compatibility, we'll still need to support both system properties, but we will prioritize the new value http.nonProxyHosts.