Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecoyScrambler now accounts for modifications #795

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

Alexander-Sol
Copy link
Contributor

Now, when creating scrambled decoy proteins, modifications come along for the ride.

Rearranges the OneBasedPossibleLocalizedModifications dictionary to correspond to the new scrambled protein sequenc

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.47%. Comparing base (a78eea2) to head (838df4f).
Report is 1 commits behind head on master.

Files Patch % Lines
mzLib/Proteomics/Protein/Protein.cs 87.17% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   75.46%   75.47%   +0.01%     
==========================================
  Files         201      201              
  Lines       30814    30851      +37     
  Branches     3106     3112       +6     
==========================================
+ Hits        23254    23286      +32     
- Misses       7035     7039       +4     
- Partials      525      526       +1     
Files Coverage Δ
mzLib/MzLibUtil/ClassExtensions.cs 100.00% <100.00%> (ø)
mzLib/Proteomics/Protein/Protein.cs 95.70% <87.17%> (-0.60%) ⬇️

Copy link
Member

@nbollis nbollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with terminal modifications? We have Modifications that are designated as Protein N/C terminal as well as Peptide N/C terminal. How are these cases handled?

mzLib/Proteomics/Protein/Protein.cs Show resolved Hide resolved
mzLib/Test/TestProteinDigestion.cs Outdated Show resolved Hide resolved
@trishorts trishorts merged commit bad5b86 into smith-chem-wisc:master Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants