MsPathFinderT result reading #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishorts
previously approved these changes
Apr 17, 2024
|
would you please add a more verbose comment to the PR that articulates all the changes |
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
zhuoxinshi and
RayMSMS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 75.30% 75.38% +0.08%
==========================================
Files 197 199 +2
Lines 30541 30655 +114
Branches 3063 3079 +16
==========================================
+ Hits 22999 23110 +111
Misses 7026 7026
- Partials 516 519 +3
|
trishorts
previously approved these changes
Apr 24, 2024
…tension inference
avcarr2
previously approved these changes
Jun 13, 2024
elaboy
approved these changes
Jul 15, 2024
RayMSMS
approved these changes
Jul 17, 2024
zhuoxinshi
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for MsPathFinderT result parsing.
Added the three types of result files from MsPathFinderT in one ResultFile Class.
This PR includes changes from adding in fragger results and will be reduced once those get merged in.
Added Json ignore to ChemicalFormula.ThisChemicalFormula due to it being a self-referential loop.
Adjusted the scope of all custom CsvHelper converters to be internal as they are not needed outside of the Readers project