This repository was archived by the owner on Aug 2, 2024. It is now read-only.
Refactor polaris-labelled#361
Closed
vladucu wants to merge 6 commits into
Closed
Conversation
andrewpye
reviewed
Aug 9, 2019
| super.init(...arguments); | ||
|
|
||
| deprecate( | ||
| `[polaris-labelled] Passing 'dataTestLabelled' is deprecated! Switch to angle bracket invocation and pass an HTML attribute instead`, |
| @disabled={{@action.disabled}} | ||
| @loading={{@action.loading}} | ||
| @accessibilityLabel={{@action.accessibilityLabel}} | ||
| @onClick={{action @action.onAction}} |
Member
There was a problem hiding this comment.
HURRY UP AND GIVE US SPL@TTRIBUTES PLZ EMBER/GLIMMER 😅
| matchId: 'ember-polaris.polaris-labelled.dataTestLabelled-arg', | ||
| }, | ||
| ], | ||
| }; |
Member
There was a problem hiding this comment.
Curious, why do we want to silence these in the dummy app? 🤔
Member
Author
There was a problem hiding this comment.
to reduce the noise while working through these PRs
Member
|
You have some test failures that need to be taken care of before merging this 😉 |
Member
Author
|
lmao, added a note about tests to most PRs but not this one that happens with ember-beta....seems an issue unrelated to our code possibly related to ember-decorators/ember-decorators#451 |
andrewpye
approved these changes
Aug 9, 2019
vladucu
force-pushed
the
refactor/es6-polaris-drop-zone
branch
from
8ecfcfa to
f0772ac
Compare
vladucu
force-pushed
the
refactor/es6-polaris-labelled
branch
from
c0e1b54 to
9214b53
Compare
vladucu
force-pushed
the
refactor/es6-polaris-labelled
branch
from
9214b53 to
fa5354c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's here