This repository was archived by the owner on Aug 2, 2024. It is now read-only.
Refactor polaris-drop-zone#359
Merged
Merged
Conversation
vladucu
force-pushed
the
refactor/es6-polaris-drop-zone
branch
from
0c22277 to
e333457
Compare
vladucu
changed the base branch from
refactor/es6-polaris-button
to
refactor/es6-classes
vladucu
force-pushed
the
refactor/es6-polaris-drop-zone
branch
from
e333457 to
0c98746
Compare
vladucu
force-pushed
the
refactor/es6-polaris-drop-zone
branch
2 times, most recently
from
f0772ac to
43ea1c8
Compare
tomnez
reviewed
Aug 9, 2019
Contributor
tomnez
left a comment
tomnez
left a comment
There was a problem hiding this comment.
This is awesome 🙏 Just a couple comments, nothing major.
| 'state', | ||
| 'sizeClass' | ||
| ); | ||
| @computed() |
Contributor
There was a problem hiding this comment.
do we want to keep the .readOnly() on all these CPs?
Member
Author
There was a problem hiding this comment.
no, having a computed property with only a getter....trying to set it, should throw an error
| * input element works. This should be a user activation. | ||
| * | ||
| * Following warning will be logged | ||
| * `File chooser dialog can only be shown with a user activation.` |
| (component "wrapper-element" tagName="") | ||
| ) as |Wrapper|}} | ||
| <Wrapper | ||
| @id={{this.id}} |
Contributor
There was a problem hiding this comment.
Should this be @id instead of this.id since id is a public attribute?
Member
Author
There was a problem hiding this comment.
yes indeed...good catch
fixed
vladucu
force-pushed
the
refactor/es6-polaris-drop-zone
branch
from
43ea1c8 to
940d938
Compare
vladucu
force-pushed
the
refactor/es6-classes
branch
from
ca07506 to
04f5786
Compare
vladucu
force-pushed
the
refactor/es6-polaris-drop-zone
branch
from
940d938 to
43d372b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's here
NOTE
Tests are failing on beta & canary, likely related to ember-decorators/ember-decorators#451