Optional Prefix path argument on compress methods #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix error when compiling with old versions of zlib |
|
Added Python3 Unicode object handling |
This was referenced May 7, 2018
|
Thank you @veon82 its a lot of work! |
|
@smihica this 0.2.2 version is not pushed pypi. Any reason? |
|
I have uploaded. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a trivial implementation that adds a functionality to the existing compress and compress_multiple methods.
The produced zip file, if prefix path is specified, can store internal files with a specified path instead of flattening the contents of the archive.
Also some compile-time warnings on py_miniunz.c are fixed.