Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden pages are not routed by "withDoktypes" (and others) #27

Open
schliesser opened this issue Dec 2, 2024 · 0 comments · May be fixed by #28
Open

Hidden pages are not routed by "withDoktypes" (and others) #27

schliesser opened this issue Dec 2, 2024 · 0 comments · May be fixed by #28

Comments

@schliesser
Copy link

We ran into routing issues with the usage of "withDoktypes" on hidden pages as the routing did not match the site.

The QueryBuilders in the ConfigurationModifier Class have by default some query restrictions set. I would argue that all but the DeletedRestriction should be removed to have proper routing also on hidden and start/end-time records/pages.

Suggestion:

Remove all restrictions but the DeletedRestriction.

$queryBuilder->getRestrictions()->removeAll()->add(GeneralUtility::makeInstance(DeletedRestriction::class));
schliesser added a commit to schliesser/typo3-dynamic-routing-pages that referenced this issue Dec 2, 2024
@schliesser
Respect hidden records in routing
cd40e5a 
Removes the default restrictions "HiddenRestriction", "StartTimeRestriction" and "EndTimeRestriction". But keeps the "DeletedRestriction".

Editors can now preview pages etc. with proper routing.

Closes smichaelsen#27
@schliesser schliesser linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect hidden records in routing schliesser/typo3-dynamic-routing-pages
1 participant
@schliesser