Repository navigation
Add GLM-4.6 nightly benchmark coverage #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
36d7cd0
d19bc04
c294bd5
47de2ff
1602eb9
b2ba4ed
d62ef6e
bbe6089
e5d0486
230db89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,11 @@ | |
| and concurrency levels. No performance thresholds — results are uploaded | ||
| as artifacts for tracking over time. | ||
|
|
||
| Each model has Single (1 worker) and Multi (N workers) classes, both | ||
| parametrized with http and grpc backends. The workflow matrix crosses | ||
| model × variant (single/multi × sglang/vllm); both protocols run for | ||
| all runtimes. | ||
| Each model always has a Single (1 worker) class, and models with | ||
| `multi_workers > 1` also get a Multi (N workers) class. Both variants | ||
| are parametrized with http and grpc backends. The workflow matrix | ||
| crosses the generated variants with sglang and vllm runtimes, and both | ||
| protocols run for all runtimes. | ||
|
|
||
| genai-bench defaults (omitted flags): | ||
| - Concurrency: [1, 2, 4, 8, 16, 32, 64, 128, 256] | ||
|
|
@@ -102,6 +103,7 @@ def _run_nightly(setup_backend, genai_bench_runner, model_id, worker_count=1, ** | |
| ("Qwen/Qwen3-30B-A3B", "Qwen30b", 4, ["http", "grpc"], {}), | ||
| ("openai/gpt-oss-20b", "GptOss20b", 1, ["http", "grpc"], {}), | ||
| ("minimaxai/minimax-m2", "MinimaxM2", 1, ["http", "grpc"], {}), | ||
| ("zai-org/GLM-4.6", "Glm46", 1, ["http", "grpc"], {}), | ||
|
slin1237 marked this conversation as resolved.
Resolved
|
||
| ( | ||
| "meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8", | ||
| "Llama4Maverick", | ||
|
|
@@ -142,12 +144,16 @@ def test_nightly_perf(self, setup_backend, genai_bench_runner): | |
|
|
||
|
|
||
| for _model_id, _name, _multi_workers, _backends, _extra in _NIGHTLY_MODELS: | ||
| for _suffix, _count in [("Single", 1), ("Multi", _multi_workers)]: | ||
| variants = [("Single", 1)] | ||
|
nishanthp marked this conversation as resolved.
Resolved
|
||
| if _multi_workers > 1: | ||
| variants.append(("Multi", _multi_workers)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This new guard stops generating Useful? React with 👍 / 👎.
slin1237 marked this conversation as resolved.
Resolved
|
||
|
|
||
| for _suffix, _count in variants: | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| _cls_name = f"TestNightly{_name}{_suffix}" | ||
| _cls = _make_test_class(_model_id, _count, _backends, _extra) | ||
| _cls.__name__ = _cls_name | ||
| _cls.__qualname__ = _cls_name | ||
| globals()[_cls_name] = _cls | ||
|
|
||
| # Clean up loop variables from module namespace | ||
| del _model_id, _name, _multi_workers, _backends, _extra, _suffix, _count, _cls_name, _cls | ||
| del _model_id, _name, _multi_workers, _backends, _extra, _suffix, _count, _cls_name, _cls, variants | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,14 @@ def _resolve_model_path(hf_path: str) -> str: | |
| "worker_args": ["--trust-remote-code"], | ||
| "vllm_args": ["--trust-remote-code"], | ||
| }, | ||
| # GLM-4.6 - nightly benchmarks | ||
| "zai-org/GLM-4.6": { | ||
| "model": _resolve_model_path("zai-org/GLM-4.6"), | ||
| "tp": 8, | ||
|
nishanthp marked this conversation as resolved.
Resolved
|
||
| "features": ["chat", "streaming", "function_calling", "reasoning"], | ||
| "worker_args": ["--trust-remote-code"], | ||
| "vllm_args": ["--trust-remote-code"], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need this parameter for this one. No |
||
| }, | ||
|
nishanthp marked this conversation as resolved.
Resolved
|
||
| # Vision-language model for multimodal benchmarks (MMMU) | ||
| "Qwen/Qwen3-VL-8B-Instruct": { | ||
| "model": _resolve_model_path("Qwen/Qwen3-VL-8B-Instruct"), | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.