Repository navigation
Conversation
Signed-off-by: key4ng <rukeyang@gmail.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated GitHub Actions workflows to replace Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
Closing this PR because the branch name To fix this, please rename your branch locally, push the new branch, and open a new PR: git branch -m <new-branch-name>
git push origin -u <new-branch-name> |
|
Hi @key4ng, the branch Please use one of the following formats:
Allowed types:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3ae25d073
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| E2E_RUNTIME=${{ matrix.variant.runtime }} \ | ||
| ROUTER_LOCAL_MODEL_PATH="/raid/models" \ | ||
| HF_HOME="/models" \ |
There was a problem hiding this comment.
Preserve ROUTER_LOCAL_MODEL_PATH in benchmark invocation
Switching this env var to HF_HOME breaks the local-model path plumbing used by the benchmark fixtures: get_model_spec() only checks ROUTER_LOCAL_MODEL_PATH when resolving model paths (e2e_test/infra/model_specs.py), and benchmark command construction only mounts/uses local tokenizer directories when ROUTER_LOCAL_MODEL_PATH is set (e2e_test/benchmarks/conftest.py). In this configuration, tests fall back to Hub model IDs instead of the mounted PVC model tree, which can cause nightly/CI benchmark runs to download from Hugging Face (or fail on gated/offline environments) instead of using local models.
Useful? React with 👍 / 👎.
Description
Problem
Solution
Changes
Test Plan
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit