Repository navigation
fix(ci): drop [grpc] extra from nightly vllm install - #826
Conversation
The nightly vllm wheel doesn't have the [grpc] extra defined, causing install failures. Install vllm without extras — the smg-grpc-servicer is already installed from source in the next step. Signed-off-by: Chang Su <chang.s.su@oracle.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a hotfix for the CI pipeline. It resolves an issue where Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the CI vLLM installation script to remove the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Code Review
This pull request addresses a CI failure by removing the [grpc] extra during the installation of the nightly vllm wheel. This is the correct approach as the extra is not available in the nightly build, and the necessary gRPC dependencies are installed from source in a subsequent step. To improve long-term maintainability, I've suggested adding a comment to the script to preserve the context for this change.
Signed-off-by: Chang Su <chang.s.su@oracle.com>
Hotfix: the nightly vllm wheel doesn't have the [grpc] extra, causing all vLLM CI jobs to fail at setup. Install vllm without extras — smg-grpc-servicer is already installed from source in the next step.
Summary by CodeRabbit