Skip to content

fix(ci): drop [grpc] extra from nightly vllm install - #826

Merged
CatherineSue merged 1 commit into
mainfrom
fix/ci-vllm-install
Mar 19, 2026
Merged

CatherineSue merged 1 commit into
mainfrom
fix/ci-vllm-install

Conversation

@CatherineSue

@CatherineSue CatherineSue commented Mar 19, 2026 •

Copy link
Copy Markdown
Member

Hotfix: the nightly vllm wheel doesn't have the [grpc] extra, causing all vLLM CI jobs to fail at setup. Install vllm without extras — smg-grpc-servicer is already installed from source in the next step.

Summary by CodeRabbit

  • Chores
    • Updated continuous integration setup to simplify vLLM dependency installation while maintaining CUDA version compatibility.

The nightly vllm wheel doesn't have the [grpc] extra defined,
causing install failures. Install vllm without extras — the
smg-grpc-servicer is already installed from source in the next step.

Signed-off-by: Chang Su <chang.s.su@oracle.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a hotfix for the CI pipeline. It resolves an issue where vLLM CI jobs were failing due to an incorrect installation command for the nightly vllm wheel. By removing the [grpc] extra from the installation, the CI setup can now proceed successfully, as the smg-grpc-servicer is installed separately.

Highlights

  • CI Fix: Removed the [grpc] extra from the vllm installation command in the CI script. This addresses an issue where the nightly vllm wheel does not include this extra, causing CI job failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@coderabbitai

coderabbitai Bot commented Mar 19, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 22401978-8b49-4a75-8160-435cb36f8b86

📥 Commits

Reviewing files that changed from the base of the PR and between d195426 and 9b1312c.

📒 Files selected for processing (1)
  • scripts/ci_install_vllm.sh

📝 Walkthrough

Walkthrough

Updated the CI vLLM installation script to remove the vllm[grpc] extras specification and install vllm directly, while retaining the nightly CUDA index URL. The corresponding log message was adjusted to reflect this change. No control flow or other installation steps were modified.

Changes

Cohort / File(s) Summary
CI Installation Script
scripts/ci_install_vllm.sh
Removed [grpc] extras from vLLM package installation, changed from vllm[grpc] to vllm while maintaining the nightly CUDA wheels index. Updated echoed log message accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested reviewers

  • key4ng
  • gongwei-130
  • XinyueZhang369

Poem

🐰 A swift script adjustment we make today,
Remove those grpc extras away,
vLLM stands cleaner, wheels rolling right,
Nightly builds running with less baggage in sight! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-vllm-install
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@CatherineSue
CatherineSue merged commit e231a73 into main Mar 19, 2026
10 of 11 checks passed
@CatherineSue
CatherineSue deleted the fix/ci-vllm-install branch March 19, 2026 18:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a CI failure by removing the [grpc] extra during the installation of the nightly vllm wheel. This is the correct approach as the extra is not available in the nightly build, and the necessary gRPC dependencies are installed from source in a subsequent step. To improve long-term maintainability, I've suggested adding a comment to the script to preserve the context for this change.

Comment thread scripts/ci_install_vllm.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant