Repository navigation
fix(ci): use ignore-pr-updates for stale PR detection, disable issues - #800
Conversation
actions/stale uses updated_at by default, which GitHub silently bumps for invisible events like merge conflict recalculation when main changes. This prevents stale detection from ever triggering on old PRs. Set ignore-pr-updates: true so staleness is tracked from the stale label creation date instead of updated_at. Only real activity (comments, commits) that removes the stale label resets the timer. Also disable issue processing (days-before-issue-stale: -1) to focus on PRs only for now. Signed-off-by: Chang Su <chang.s.su@oracle.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request refocuses the stale workflow automation to target pull requests exclusively. The workflow is reconfigured to disable issue staleness processing, set PR staleness thresholds to 14 days for stale marking and 16 days for closure, and adds improved staleness tracking by ignoring routine PR updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d3637465d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Use creation/update of stale label to track staleness instead of | ||
| # updated_at, which GitHub silently bumps for invisible events like | ||
| # merge conflict recalculation when main changes. | ||
| ignore-pr-updates: true |
There was a problem hiding this comment.
ignore-pr-updates from stale PR detection
actions/stale does not interpret ignore-pr-updates: true as “start counting from when the stale label was applied”; its docs say this switches the stale threshold to the PR’s created_at. In this workflow, any PR that was opened more than 14 days ago will be marked stale even if it got a real commit or comment yesterday. Because remove-pr-stale-when-updated is still at its default true, active long-lived PRs will have the stale label removed on activity and then re-added on the very next daily run, causing repeated stale comments and incorrect stale status.
Useful? React with 👍 / 👎.
…smg-project#800) Signed-off-by: Chang Su <chang.s.su@oracle.com>
…smg-project#800) Signed-off-by: Chang Su <chang.s.su@oracle.com>
1 participant
Description
Problem
Follow-up to #798. The actions/stale workflow uses updated_at by default to determine staleness. GitHub silently bumps updated_at for invisible events like merge conflict recalculation when main changes. Manual testing confirmed old PRs like #463 and #253 (inactive since Jan/Feb) were marked "not stale" because updated_at showed yesterday.
Solution
Changes
Test Plan
After merge, trigger manually via Actions tab and verify old inactive PRs receive the stale label.
Summary by CodeRabbit