Skip to content

fix(ci): use k8s pod env vars for API keys instead of GitHub secrets #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slin1237 merged 1 commit into from
Mar 17, 2026
Merged

fix(ci): use k8s pod env vars for API keys instead of GitHub secrets #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/e2e-gpu-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ jobs:
# Run tests
- name: Run E2E tests
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
XAI_API_KEY: ${{ secrets.XAI_API_KEY }}
ANTHROPIC_API_KEY: ${{ secrets.CLAUDE_API_KEY }}
SHOW_WORKER_LOGS: "0"
SHOW_ROUTER_LOGS: "1"
BRAVE_MCP_HOST: ${{ inputs.setup_agentic_deps && 'brave-search-mcp' || '' }}
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/nightly-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ jobs:
- name: Run benchmark
if: steps.filter.outputs.skip != 'true'
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
GPU_TYPE: H100
E2E_NIGHTLY: "1"
E2E_MODEL_TP_OVERRIDES: '{"meta-llama/Llama-3.1-8B-Instruct":1,"Qwen/Qwen2.5-7B-Instruct":1,"Qwen/Qwen3-30B-A3B":1}'
Expand Down Expand Up @@ -298,7 +297,6 @@ jobs:
- name: Run benchmark
if: steps.filter.outputs.skip != 'true'
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
GPU_TYPE: H100
E2E_NIGHTLY: "1"
E2E_MODEL_TP_OVERRIDES: '{"meta-llama/Llama-3.1-8B-Instruct":1,"Qwen/Qwen2.5-7B-Instruct":1,"Qwen/Qwen3-30B-A3B":1}'
Expand Down Expand Up @@ -416,7 +414,6 @@ jobs:
- name: Run benchmark
if: steps.filter.outputs.skip != 'true'
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
GPU_TYPE: H200
E2E_NIGHTLY: "1"
E2E_LOG_DIR: nightly_gateway_logs
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/pr-test-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ jobs:

- name: Run benchmarks
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
ROUTER_LOCAL_MODEL_PATH: /home/ubuntu/models
run: |
bash scripts/ci_killall_sglang.sh "nuk_gpus"
Expand Down Expand Up @@ -665,9 +664,6 @@ jobs:

- name: Run E2E tests
env:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
XAI_API_KEY: ${{ secrets.XAI_API_KEY }}
ANTHROPIC_API_KEY: ${{ secrets.CLAUDE_API_KEY }}
BRAVE_MCP_HOST: ${{ matrix.setup_agentic_deps && 'brave-search-mcp' || '' }}
Comment on lines 665 to 667

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep vendor API keys wired for e2e-vendor jobs

This step now relies entirely on runner-level API key environment variables, but in the checked-in ARC runner configs (scripts/k8s-runner-resources/runner-values-*.yaml) the runner container env only defines Docker-related vars and does not inject OPENAI_API_KEY, XAI_API_KEY, or ANTHROPIC_API_KEY. The vendor test fixture fails hard when those vars are absent (e2e_test/fixtures/setup_backend.py checks api_key_env and calls pytest.fail), so deployments that follow the repo’s runner manifests will fail these jobs after this change unless a fallback (for example GitHub secrets) is kept or the runner env injection is added in-repo.

Useful? React with 👍 / 👎.

run: |
ROUTER_LOCAL_MODEL_PATH="/home/ubuntu/models" pytest ${{ matrix.test_path }} \
Expand Down Expand Up @@ -779,8 +775,6 @@ jobs:
bash scripts/ci_install_e2e_deps.sh

- name: Run Go OAI server E2E tests
env:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
run: |
bash scripts/ci_killall_sglang.sh "nuk_gpus"
export CGO_LDFLAGS="-L$(pwd)/bindings/golang/target/release"
Expand Down