Repository navigation
fix(ci): add packages:write permission to engine docker release workflows - #697
Conversation
…lows The engine docker workflows (sglang, vllm, trtllm) failed to push images to GHCR with "installation not allowed to Write organization package" because the GITHUB_TOKEN only had Packages: read. Add permissions block with contents: read and packages: write to all three workflows, matching the nightly-docker.yml pattern. Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds a top-level permissions block to three Docker release GitHub Actions workflows, explicitly granting read access to repository contents and write access to container packages. This enables the workflows to authenticate with the container registry for pushing Docker images. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Summary
Fixes GHCR push failure in engine docker release workflows (sglang, vllm, trtllm).
What changed
permissions: contents: read, packages: writetorelease-sglang-docker.yml,release-vllm-docker.yml,release-trtllm-docker.ymlWhy
The workflows failed with
error from registry: installation not allowed to Write organization packagebecause theGITHUB_TOKENonly hadPackages: read. Thenightly-docker.ymlworkflow already has this permission set correctly — this brings the engine release workflows in line.Test plan
nightly-docker.ymluses the same permissions patternSummary by CodeRabbit