Skip to content

fix(ci): add memory limits to 4-gpu-h100 runner to prevent benchmark OOM #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CatherineSue wants to merge 1 commit into from
Closed

fix(ci): add memory limits to 4-gpu-h100 runner to prevent benchmark OOM #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/k8s-runner-resources/runner-values-4-gpu-h100.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,11 @@ template:
- name: RUNNER_WAIT_FOR_DOCKER_IN_SECONDS
value: '120'
resources:
requests:
memory: "128Gi"

@gemini-code-assist gemini-code-assist Bot Mar 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved clarity and consistency, it's good practice to explicitly define the GPU request alongside the memory request. While Kubernetes implicitly sets the request equal to the limit when it's not specified, making it explicit enhances the readability of the pod's resource requirements. This also aligns with the pattern used in runner-values-cpu.yaml where all resources are explicitly requested.

            nvidia.com/gpu: 4
            memory: "128Gi"

limits:
nvidia.com/gpu: 4
memory: "128Gi"
volumeMounts:
- name: model-cache
mountPath: /models
Expand Down
Loading