fix(grpc-proto): reorder authors in pyproject.toml - #400
Conversation
Summary of ChangesHello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the PyPI page for Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reorders the authors in the pyproject.toml file. The change correctly reflects the intention described in the pull request, which is to list Chang Su as the first author. The modification is straightforward and I see no issues with it.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe authors list in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
Signed-off-by: ppraneth <pranethparuchuri@gmail.com>
Description
Problem
The PyPI page for smg-grpc-proto shows Simo Lin as the first author, but Chang Su should be listed first.
Solution
Reorder the authors list in
grpc_client/python/pyproject.tomlto put Chang Su first.Changes
Test Plan
Metadata-only change. The updated author order will be reflected on PyPI when the next version is published.
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit