Skip to content

chore(deps): update redis requirement from 0.27.6 to 1.0.3 - #395

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/redis-1.0.3
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/redis-1.0.3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Feb 10, 2026

Copy link
Copy Markdown
Contributor

Updates the requirements on redis to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [redis](https://github.com/redis-rs/redis-rs) to permit the latest version.
- [Release notes](https://github.com/redis-rs/redis-rs/releases)
- [Commits](https://github.com/redis-rs/redis-rs/commits)

---
updated-dependencies:
- dependency-name: redis
  dependency-version: 1.0.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Dependency updates rust Pull requests that update rust code labels Feb 10, 2026
@dependabot
dependabot Bot requested a review from key4ng as a code owner February 10, 2026 19:20
@dependabot dependabot Bot added dependencies Dependency updates rust Pull requests that update rust code labels Feb 10, 2026
@github-actions github-actions Bot added the data-connector Data connector crate changes label Feb 10, 2026
@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@slin1237

Copy link
Copy Markdown
Member

Closing this — the upgrade to redis 1.0.3 is blocked by deadpool-redis.

deadpool-redis 0.18.0 (our current version) depends on redis ^0.27, which causes two incompatible versions of redis in the dependency graph. The build fails with 47 errors because deadpool_redis::Connection implements redis 0.27's ConnectionLike trait, not redis 1.0's.

The latest deadpool-redis (0.22.1) still only supports redis ^0.32 — not 1.x. There's an open upstream issue tracking this: deadpool-rs/deadpool#447

We can revisit once deadpool-redis releases a version compatible with redis 1.x.

@dependabot ignore this major version

@dependabot dependabot Bot closed this Feb 11, 2026
@dependabot @github

dependabot Bot commented on behalf of github Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you about version 1.x.x again, unless you re-open this PR.

@dependabot
dependabot Bot deleted the dependabot/cargo/redis-1.0.3 branch February 11, 2026 17:41
yetone added a commit that referenced this pull request Apr 24, 2026
…red`` + debug dump

The xfail helper was written against an old TokenSpeed main where
``create_grammar_backend()`` was defined but never called and
``Request.grammar`` was never assigned. That's no longer the case —
TokenSpeed's grammar pipeline is fully wired as of #236 + #381 + #395:

- ``request_handler.py`` instantiates ``GrammarManager``
- ``event_loop.py`` routes new requests through
  ``process_req_with_grammar`` + ``get_ready_grammar_requests``, with an
  async compile queue and abort support
- ``greedy.py`` / ``flashinfer*.py`` both apply ``sampling_info.vocab_mask``
  to logits before sampling when a grammar is active
- speculative (``eagle_utils.py:773``) and disagg decode paths already
  call ``grammar.accept_token``

So ``tokenspeed#361``'s surface (``sampling_params.json_schema`` →
``req.grammar`` → vocab mask) now works end-to-end. The three
``tool_choice=required/specific`` tests that were xfailed should run on
tokenspeed just like they do on sglang/vllm/trtllm; CI will confirm.

Also drops the short-lived debug dumps in ``servicer.py`` and the
``TOKENSPEED_DEBUG_OUTPUT=1`` toggle in ``e2e-gpu-job.yml`` — those were
staged to diagnose why meta-llama tool-call tests diverged from unsloth.
The diagnosis is done: output trimming is correct, chunks are
incremental, the remaining unconstrained (tool_choice=auto) drift is a
sampling-variance quality issue orthogonal to this PR.

Signed-off-by: yetone <yetoneful@gmail.com>
yetone added a commit that referenced this pull request Apr 27, 2026
…red`` + debug dump

The xfail helper was written against an old TokenSpeed main where
``create_grammar_backend()`` was defined but never called and
``Request.grammar`` was never assigned. That's no longer the case —
TokenSpeed's grammar pipeline is fully wired as of #236 + #381 + #395:

- ``request_handler.py`` instantiates ``GrammarManager``
- ``event_loop.py`` routes new requests through
  ``process_req_with_grammar`` + ``get_ready_grammar_requests``, with an
  async compile queue and abort support
- ``greedy.py`` / ``flashinfer*.py`` both apply ``sampling_info.vocab_mask``
  to logits before sampling when a grammar is active
- speculative (``eagle_utils.py:773``) and disagg decode paths already
  call ``grammar.accept_token``

So ``tokenspeed#361``'s surface (``sampling_params.json_schema`` →
``req.grammar`` → vocab mask) now works end-to-end. The three
``tool_choice=required/specific`` tests that were xfailed should run on
tokenspeed just like they do on sglang/vllm/trtllm; CI will confirm.

Also drops the short-lived debug dumps in ``servicer.py`` and the
``TOKENSPEED_DEBUG_OUTPUT=1`` toggle in ``e2e-gpu-job.yml`` — those were
staged to diagnose why meta-llama tool-call tests diverged from unsloth.
The diagnosis is done: output trimming is correct, chunks are
incremental, the remaining unconstrained (tool_choice=auto) drift is a
sampling-variance quality issue orthogonal to this PR.

Signed-off-by: yetone <yetoneful@gmail.com>
CatherineSue pushed a commit that referenced this pull request Apr 30, 2026
…red`` + debug dump

The xfail helper was written against an old TokenSpeed main where
``create_grammar_backend()`` was defined but never called and
``Request.grammar`` was never assigned. That's no longer the case —
TokenSpeed's grammar pipeline is fully wired as of #236 + #381 + #395:

- ``request_handler.py`` instantiates ``GrammarManager``
- ``event_loop.py`` routes new requests through
  ``process_req_with_grammar`` + ``get_ready_grammar_requests``, with an
  async compile queue and abort support
- ``greedy.py`` / ``flashinfer*.py`` both apply ``sampling_info.vocab_mask``
  to logits before sampling when a grammar is active
- speculative (``eagle_utils.py:773``) and disagg decode paths already
  call ``grammar.accept_token``

So ``tokenspeed#361``'s surface (``sampling_params.json_schema`` →
``req.grammar`` → vocab mask) now works end-to-end. The three
``tool_choice=required/specific`` tests that were xfailed should run on
tokenspeed just like they do on sglang/vllm/trtllm; CI will confirm.

Also drops the short-lived debug dumps in ``servicer.py`` and the
``TOKENSPEED_DEBUG_OUTPUT=1`` toggle in ``e2e-gpu-job.yml`` — those were
staged to diagnose why meta-llama tool-call tests diverged from unsloth.
The diagnosis is done: output trimming is correct, chunks are
incremental, the remaining unconstrained (tool_choice=auto) drift is a
sampling-variance quality issue orthogonal to this PR.

Signed-off-by: yetone <yetoneful@gmail.com>
key4ng pushed a commit that referenced this pull request Apr 30, 2026
…red`` + debug dump

The xfail helper was written against an old TokenSpeed main where
``create_grammar_backend()`` was defined but never called and
``Request.grammar`` was never assigned. That's no longer the case —
TokenSpeed's grammar pipeline is fully wired as of #236 + #381 + #395:

- ``request_handler.py`` instantiates ``GrammarManager``
- ``event_loop.py`` routes new requests through
  ``process_req_with_grammar`` + ``get_ready_grammar_requests``, with an
  async compile queue and abort support
- ``greedy.py`` / ``flashinfer*.py`` both apply ``sampling_info.vocab_mask``
  to logits before sampling when a grammar is active
- speculative (``eagle_utils.py:773``) and disagg decode paths already
  call ``grammar.accept_token``

So ``tokenspeed#361``'s surface (``sampling_params.json_schema`` →
``req.grammar`` → vocab mask) now works end-to-end. The three
``tool_choice=required/specific`` tests that were xfailed should run on
tokenspeed just like they do on sglang/vllm/trtllm; CI will confirm.

Also drops the short-lived debug dumps in ``servicer.py`` and the
``TOKENSPEED_DEBUG_OUTPUT=1`` toggle in ``e2e-gpu-job.yml`` — those were
staged to diagnose why meta-llama tool-call tests diverged from unsloth.
The diagnosis is done: output trimming is correct, chunks are
incremental, the remaining unconstrained (tool_choice=auto) drift is a
sampling-variance quality issue orthogonal to this PR.

Signed-off-by: yetone <yetoneful@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-connector Data connector crate changes dependencies Dependency updates rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant