Repository navigation
chore[ci]: upgrade oracle image - #393
Conversation
📝 WalkthroughWalkthroughThe GitHub Actions Rust PR workflow's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/pr-test-rust.yml:
- Line 321: The workflow uses the gvenzl/oracle-free image (matrix.setup_oracle)
but the DSN still references the old pluggable database name XEPDB1; locate the
job step that sets the Oracle connection string/DSN (the env var or string
containing "XEPDB1", e.g., ORACLE_DSN or the connection string used to run
tests) and change the PDB name to FREEPDB1 so the DSN matches the
gvenzl/oracle-free default; ensure any other references to XEPDB1 in that
workflow are updated accordingly.
Signed-off-by: ppraneth <pranethparuchuri@gmail.com>
Description
Problem
Got warning from current docker container
Solution
upgrade image based on the suggestion. remove useless docker warmup step
Changes
Test Plan
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit