Skip to content

chore[ci]: upgrade oracle image - #393

Merged
key4ng merged 2 commits into
mainfrom
oracle-image
Feb 10, 2026
Merged

key4ng merged 2 commits into
mainfrom
oracle-image

Conversation

@key4ng

@key4ng key4ng commented Feb 10, 2026 •

Copy link
Copy Markdown
Member

Description

Problem

Got warning from current docker container

NOTICE: YOU ARE USING AN OLD IMAGE VERSION!
 PLEASE CONSIDER UPGRADING TO gvenzl/oracle-free!

Solution

upgrade image based on the suggestion. remove useless docker warmup step

Changes

Test Plan

Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated

Summary by CodeRabbit

  • Chores
    • Updated CI workflows: replaced Oracle Docker image with a newer variant, removed a Docker daemon warm‑up step from the pipeline, and adjusted the Oracle connection identifier used in CI environment setup.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Feb 10, 2026
@coderabbitai

coderabbitai Bot commented Feb 10, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The GitHub Actions Rust PR workflow's gateway-e2e job switches the Oracle image to gvenzl/oracle-free:23-slim-faststart, removes a conditional Docker daemon warm-up step, and updates the Oracle DSN to localhost:1521/FREEPDB1.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
​.github/workflows/pr-test-rust.yml
In gateway-e2e job: changed Oracle image from gvenzl/oracle-xe:21-slim-faststart to gvenzl/oracle-free:23-slim-faststart; removed the conditional "Warm up Docker daemon" step; updated Oracle DSN from localhost:1521/XEPDB1 to localhost:1521/FREEPDB1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • CatherineSue
  • XinyueZhang369
  • slin1237

Poem

🐇
Oracle hops to twenty-three, light and spry,
No daemon yawns or stalls to pry,
A DSN tucked in a newer nest,
CI wakes up, ready to test,
Hooray — the pipeline takes a jaunty sky!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: upgrading the Oracle Docker image from version 21 to version 23 (oracle-xe to oracle-free).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch oracle-image

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/pr-test-rust.yml:
- Line 321: The workflow uses the gvenzl/oracle-free image (matrix.setup_oracle)
but the DSN still references the old pluggable database name XEPDB1; locate the
job step that sets the Oracle connection string/DSN (the env var or string
containing "XEPDB1", e.g., ORACLE_DSN or the connection string used to run
tests) and change the PDB name to FREEPDB1 so the DSN matches the
gvenzl/oracle-free default; ensure any other references to XEPDB1 in that
workflow are updated accordingly.

Comment thread .github/workflows/pr-test-rust.yml
@key4ng
key4ng merged commit 5bc3a25 into main Feb 10, 2026
20 checks passed
@key4ng
key4ng deleted the oracle-image branch February 10, 2026 19:51
ppraneth pushed a commit that referenced this pull request Feb 18, 2026
Signed-off-by: ppraneth <pranethparuchuri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants