Repository navigation
test: restrict Linux shared-memory tests to Linux - #2860
Merged
Merged
Conversation
Signed-off-by: Alex McC <319643551+hello-alexmcc@users.noreply.github.com>
hello-alexmcc
requested review from
CatherineSue,
key4ng and
slin1237
as code owners
October 7, 2026 20:29
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughTwo shared-memory tests are now compiled only on Linux. Their test logic and assertions are unchanged. ChangesLinux-only test gates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to Only the platform eligibility of two 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Two shared-memory tests write directly to Linux’s
/dev/shmand fail on macOS withNo such file or directorybefore reaching their assertions.Solution
Compile these two tests only on Linux. Their Linux execution and assertions remain intact, including failure when the expected shared-memory mount is unavailable. Portable multimodal tests continue to run on all platforms.
Changes
#[cfg(target_os = "linux")]to the servicer’s SHM fan-out test and the adapter’s SHM offset/unlink test.Test Plan
cargo test -p engine-servicer -p engine-zmq-adapter --no-fail-fast— 170 servicer unit tests, 2 integration tests, and 73 adapter tests passed; 0 failures.cargo clippy -p engine-servicer -p engine-zmq-adapter --all-targets -- -D warnings -A clippy::collapsible_match— passed. The sole lint exception is the existing test-helper warning fixed separately in test(engine-servicer): fix collapsible match lint in KV wire tests #2859.cargo +nightly fmt --allandgit diff --check— passed.Validation ran on macOS; the two Linux-only tests require Linux CI for execution. Full-workspace gates have other pre-existing Linux-specific benchmark/test assumptions and were not rerun for this two-line change.
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspasses (scoped Clippy passed with the exception documented above)Release note
The two Linux-only shared-memory tests compile only on Linux, so the servicer and adapter suites pass on other platforms too.
Numbers