Repository navigation
fix(pd): serve multimodal requests on language-model-only vLLM decode workers #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8ec84f2
fix(pd): serve multimodal requests on language-model-only vLLM decode…
ywang96 922f20e
fix(pd): probe vision capability via the vLLM registry on older engines
ywang96 c31beae
refactor(pd): read the supports_vision label through the shared constant
ywang96 b4c7721
fix(pd): require a KV handoff before dispatching a stripped mm decode…
ywang96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Nit:
_mm_embeds_onlyiterates only the explicitly configuredlimit_per_promptkeys, while vLLM's own embeds-only check iterates the model's supported modalities (info.supported_mm_limits). The two diverge whenenable_mm_embeds=Trueand the operator zeroes a subset of modalities, e.g.--limit-mm-per-prompt image=0on an image+video model: every explicit limit is 0, so this returnsTrueand the worker advertisessupports_vision=false, even though the video encoder is still live (default non-zero limit). That misclassifies a healthy encoder-bearing worker — the same "don't blind a healthy worker" direction theexcept Exceptionhandler in_registry_supports_multimodal_inputsdeliberately guards against — and for an M-RoPE model would turn a valid P/D pairing into a hardpd_decode_language_model_only_mrope400. Niche config, so not blocking, but if the model's supported-modality set (or a fully populatedlimit_per_prompt) is reachable here, iterating that instead would close the gap.