Skip to content

feat(kv-events): route using reported KV cache groups #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ai-jz wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(kv-events): route using reported KV cache groups #2497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1459850
feat(kv-events): route using reported KV cache groups
ai-jz Sep 10, 2026
2377109
fix(kv-events): accept older group event metadata
ai-jz Sep 10, 2026
d1b85ed
perf(kv-events): reuse radix contexts for group matching
ai-jz Sep 11, 2026
bd67585
docs(kv-events): show current matcher scaling
ai-jz Sep 11, 2026
0304756
fix(kv-index): reclaim evicted group history with radix GC
ai-jz Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-test-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ jobs:
- name: Run Python unit tests
run: |
cd bindings/python
python3 -m pip install pytest pytest-cov pytest-xdist
python3 -m pip install pytest pytest-asyncio pytest-cov pytest-xdist

@claude claude Bot Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Nit: pytest-asyncio is installed by the bindings/python step but the tests that need it live in grpc_servicer/tests (the @pytest.mark.asyncio cases this PR adds in test_vllm_kv_group_events.py, plus the pre-existing ones in test_vllm_kv_events_stream.py / test_tokenspeed_kv_events_stream.py). It works only because both steps share one job's interpreter.

That coupling is invisible and load-bearing: if the grpc_servicer step is ever split into its own job, reordered, or the bindings/python step's deps are trimmed, the async tests do not fail loudly — under strict mode with no plugin they are skipped with a warning, so the group-event subscription and corrupt-frame tests would go green while never running. Installing it in the step that consumes it (or adding it to grpc_servicer's dev extras) makes the dependency survive that refactor.

pytest -q tests --cov=smg --cov-config=.coveragerc --cov-report=term-missing --cov-fail-under=80

- name: Run grpc_servicer unit tests
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-crates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ jobs:
path: crates/protocols
- crate: reasoning-parser
path: crates/reasoning_parser
- crate: kv-index
path: crates/kv_index
- crate: data-connector
path: crates/data_connector
- crate: wfaas
Expand Down Expand Up @@ -59,6 +57,8 @@ jobs:
fail-fast: false
matrix:
include:
- crate: kv-index
path: crates/kv_index
- crate: tool-parser
path: crates/tool_parser
- crate: smg-grpc-client
Expand Down
5 changes: 3 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ llm-tokenizer = { version = "1.7.0", path = "crates/tokenizer" }
smg-auth = { version = "1.2.3", path = "crates/auth" }
smg-mcp = { version = "2.3.3", path = "crates/mcp" }
smg-external-router = { version = "0.1.0", path = "crates/external_router" }
kv-index = { version = "1.4.0", path = "crates/kv_index" }
smg-radix-tree = { version = "0.1.0", path = "crates/radix_tree" }
kv-index = { version = "1.5.0", path = "crates/kv_index" }
smg-radix-tree = { version = "0.1.1", path = "crates/radix_tree" }
smg-data-connector = { version = "2.3.4", path = "crates/data_connector", package = "data-connector" }
llm-multimodal = { version = "1.11.0", path = "crates/multimodal" }
smg-wasm = { version = "1.1.4", path = "crates/wasm", package = "smg-wasm" }
Expand Down
Loading
Loading