Repository navigation
fix(router): import Bytes for the stream-relay channel type - #2141
Conversation
The relay channel in send_typed_request names bytes::Bytes by full path, tripping the workspace unused_qualifications lint and failing the lint lane on every PR. Import the type and drop the qualification. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe HTTP router now imports ChangesRouter type cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This is a localized lint-only cleanup that preserves the existing stream-relay type and runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
👋 The PR description doesn't fully follow
Please update the PR description so reviewers have the context they need. |
Motivation
main's lint lane is currently red: the stream-relay channel insend_typed_request(model_gateway/src/routers/http/router.rs) namesbytes::Bytesby full path, which trips the workspace-wideunused_qualificationslint. Every open PR now fails thelintjob through no fault of its own.Modifications
bytes::Bytesinmodel_gateway/src/routers/http/router.rsand drop the path qualification on the relay channel's type parameter.Test Plan
cargo +nightly fmt --all— cleancargo clippy -p smg --lib -- -D warnings— clean (previously failed withunnecessary qualification)cargo clippy -p smg --all-targets -- -D warnings— cleanOne-line type-path change; no behavior difference.
Related Issues
Unblocks the
lintlane for all open PRs (first observed on #2138's run).