Skip to content

ci: increase gpu timeout budgets - #1721

Merged
key4ng merged 2 commits into
mainfrom
fix/ci-timeout-budgets
Jun 13, 2026
Merged

key4ng merged 2 commits into
mainfrom
fix/ci-timeout-budgets

Conversation

@key4ng

@key4ng key4ng commented Jun 13, 2026 •

Copy link
Copy Markdown
Member

Description

Problem

Two GPU CI jobs are timing out even though the underlying workers are not crashing:

  • Benchmark run 27478078225 / job 81220991394 completed the HTTP benchmark and wrote results, but the genai-bench subprocess hit the default 240s harness timeout while it was still saving reports.
  • Chat run 27479120581 / job 81223683996 hit the 20-minute Run E2E tests step timeout after slow SGLang large-model startup and a rerun consumed most of the shard budget.

Solution

Increase the affected CI timeout budgets so these jobs have enough room for slow tokenizer/report startup and large-model reloads.

Changes

  • Increase the standalone benchmark job timeout from 30 to 36 minutes.
  • Set GENAI_BENCH_TEST_TIMEOUT=480 for the benchmark job.
  • Increase the 1GPU SGLang chat job timeout from 28 to 36 minutes.
  • Increase the 1GPU SGLang chat pytest step timeout from 20 to 28 minutes.

Test Plan

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/pr-test-rust.yml"); puts "yaml ok"'
  • pre-commit run --files .github/workflows/pr-test-rust.yml
Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Summary by CodeRabbit

  • Chores
    • Increased CI job timeouts for benchmark and test workflows.
    • Set a longer benchmark test timeout via environment configuration.
    • Extended end-to-end job and per-test timeouts for the sglang engine matrix.

Signed-off-by: key4ng <rukeyang@gmail.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates GitHub Actions workflow timeouts: standalone benchmarks job timeout increased to 36 minutes, benchmark run step adds GENAI_BENCH_TEST_TIMEOUT: "480", and the e2e-1gpu-chat sglang matrix increases job timeout and per-test test_timeout from 28/20 to 40/32.

Changes

CI Timeout Configuration Updates

Layer / File(s) Summary
Benchmark and GPU test timeout adjustments
.github/workflows/pr-test-rust.yml
Increases benchmarks job timeout-minutes 30→36; adds GENAI_BENCH_TEST_TIMEOUT: "480" to benchmark step env; increases e2e-1gpu-chat sglang timeout and test_timeout 28/20→40/32.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • lightseekorg/smg#678: Modifies .github/workflows/pr-test-rust.yml and previously adjusted benchmarks job timeout (20→30) and related e2e settings.
  • lightseekorg/smg#681: Also sets genai-bench runner timeout to 480s; strongly related to GENAI_BENCH_TEST_TIMEOUT=480 addition.
  • lightseekorg/smg#328: Edits the same GitHub Actions workflow and adjusts benchmark/e2e timeout values.

Suggested reviewers

  • CatherineSue
  • slin1237
  • XinyueZhang369

Poem

🐰
I nibbled minutes, one by one,
Benchmarks stretch beneath the sun,
Four-eighty seconds, steady and true,
GPU tests now see the view,
Hooray — more time for me and you! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ci: increase gpu timeout budgets' directly and clearly summarizes the main change: extending CI workflow timeout settings for GPU-based workloads.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-timeout-budgets

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI-only change — timeout increases are well-justified by the linked failing runs. Job/step timeout margins are consistent. LGTM.

Signed-off-by: key4ng <rukeyang@gmail.com>
Comment thread .github/workflows/pr-test-rust.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 940d292cc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +498 to +499
timeout: 36
test_timeout: 28

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the intended SGLang chat timeout budget

For the e2e-1gpu-chat (sglang) matrix entry, these two values are forwarded directly to the reusable workflow as the job timeout and the Run E2E tests step timeout (.github/workflows/e2e-gpu-job.yml:56 and :131). The change notes say this shard needs 40 minutes overall and 32 minutes for pytest after the slow SGLang startup plus rerun case, but this leaves it at 36/28, so any run in that 28–32 minute pytest window will still be cancelled before completing. Please set this entry to the intended 40/32 budget.

Useful? React with 👍 / 👎.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pr-test-rust.yml:
- Around line 498-499: The workflow currently sets timeout: 36 and test_timeout:
28 but the PR's objective is to raise the 1GPU SGLang chat lane to 40/32; update
the two keys so that timeout is set to 40 and test_timeout is set to 32 (i.e.,
replace the existing timeout: 36 and test_timeout: 28 entries with timeout: 40
and test_timeout: 32).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 07fbf155-5c69-4e0a-8bde-ae2e7b3a5b42

📥 Commits

Reviewing files that changed from the base of the PR and between b6104c5 and 940d292.

📒 Files selected for processing (1)
  • .github/workflows/pr-test-rust.yml

Comment thread .github/workflows/pr-test-rust.yml
@key4ng

key4ng commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

The failed CI doesn't related to this fix

@key4ng
key4ng merged commit c5f6f1c into main Jun 13, 2026
50 of 53 checks passed
@key4ng
key4ng deleted the fix/ci-timeout-budgets branch June 13, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant