Skip to content

ci(test): isolate e2e-2gpu-pd on 2-gpu-h100-rdma-test runner - #1702

Closed
key4ng wants to merge 1 commit into
mainfrom
keyang/ci-2gpu-pd-rdma-test
Closed

key4ng wants to merge 1 commit into
mainfrom
keyang/ci-2gpu-pd-rdma-test

Conversation

@key4ng

@key4ng key4ng commented Jun 12, 2026

Copy link
Copy Markdown
Member

Description

Problem

We need to validate the 2-GPU prefill/decode (PD) e2e suite (e2e-2gpu-pd) on
the new 2-gpu-h100-rdma-test runner without spending the full PR Test matrix on
every push.

Solution

Temporarily isolate e2e-2gpu-pd in the PR Test (SMG) workflow: keep only
build-wheel (which produces the wheel + client-type artifacts the PD job
consumes) and e2e-2gpu-pd, and disable every other job. The PD job is pointed
at the 2-gpu-h100-rdma-test runner.

Temporary / not for merge as-is. Every change is marked with the
TEMP(2gpu-pd-rdma) comment marker so it can be reverted in one pass before
this lands (or the branch is discarded once the runner is validated).

Changes

  • e2e-2gpu-pd: runner 2-gpu-h100 → 2-gpu-h100-rdma-test.
  • e2e-2gpu-pd: needs reduced from [e2e-1gpu-gateway, detect-changes] to
    [build-wheel], and the detect-changes path gating removed so it runs
    unconditionally. Matrix unchanged (sglang, vllm, vllm-mooncake).
  • All other jobs disabled via if: false (pre-commit, python-lint,
    grpc-proto-build-check, python-unit-tests, unit-tests, benchmarks,
    detect-changes, the other e2e-1gpu/4gpu jobs, e2e-vendor, go-unit-tests,
    go-bindings-e2e, finish, summarize-benchmarks).
  • Added this branch to the push trigger so CI runs on push.

Test Plan

CI on this branch should schedule exactly build-wheel → e2e-2gpu-pd (×3 matrix
legs) on the 2-gpu-h100-rdma-test runner; all other jobs report as skipped.

Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Temporarily disable all PR Test jobs except build-wheel and e2e-2gpu-pd
to validate the 2-GPU PD suite on the new 2-gpu-h100-rdma-test runner.

- e2e-2gpu-pd: runner 2-gpu-h100 -> 2-gpu-h100-rdma-test
- e2e-2gpu-pd: depend only on build-wheel and run unconditionally
  (drop e2e-1gpu-gateway dep and detect-changes path gating)
- disable every other job via 'if: false'
- add this branch to the push trigger so CI runs on push

All changes are marked with 'TEMP(2gpu-pd-rdma)' for easy revert.

Signed-off-by: key4ng <rukeyang@gmail.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d6b87f7d-f162-4bae-9092-b61827ee80e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch keyang/ci-2gpu-pd-rdma-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI-only change — temporary isolation of e2e-2gpu-pd on the RDMA test runner. All disabled jobs consistently marked with TEMP(2gpu-pd-rdma), dependency chain is correct (build-wheel → e2e-2gpu-pd), and the PR description clearly documents the temporary nature. LGTM.

@key4ng

key4ng commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

same fix already in the pr: #1705

@key4ng key4ng closed this Jun 12, 2026
@lightseek-bot
lightseek-bot deleted the keyang/ci-2gpu-pd-rdma-test branch June 12, 2026 23:40

@banafederico-smg banafederico-smg left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants