Repository navigation
Conversation
Temporarily disable all PR Test jobs except build-wheel and e2e-2gpu-pd to validate the 2-GPU PD suite on the new 2-gpu-h100-rdma-test runner. - e2e-2gpu-pd: runner 2-gpu-h100 -> 2-gpu-h100-rdma-test - e2e-2gpu-pd: depend only on build-wheel and run unconditionally (drop e2e-1gpu-gateway dep and detect-changes path gating) - disable every other job via 'if: false' - add this branch to the push trigger so CI runs on push All changes are marked with 'TEMP(2gpu-pd-rdma)' for easy revert. Signed-off-by: key4ng <rukeyang@gmail.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
CI-only change — temporary isolation of e2e-2gpu-pd on the RDMA test runner. All disabled jobs consistently marked with TEMP(2gpu-pd-rdma), dependency chain is correct (build-wheel → e2e-2gpu-pd), and the PR description clearly documents the temporary nature. LGTM.
|
same fix already in the pr: #1705 |
Description
Problem
We need to validate the 2-GPU prefill/decode (PD) e2e suite (
e2e-2gpu-pd) onthe new
2-gpu-h100-rdma-testrunner without spending the full PR Test matrix onevery push.
Solution
Temporarily isolate
e2e-2gpu-pdin thePR Test (SMG)workflow: keep onlybuild-wheel(which produces the wheel + client-type artifacts the PD jobconsumes) and
e2e-2gpu-pd, and disable every other job. The PD job is pointedat the
2-gpu-h100-rdma-testrunner.Changes
e2e-2gpu-pd: runner2-gpu-h100→2-gpu-h100-rdma-test.e2e-2gpu-pd:needsreduced from[e2e-1gpu-gateway, detect-changes]to[build-wheel], and thedetect-changespath gating removed so it runsunconditionally. Matrix unchanged (
sglang,vllm,vllm-mooncake).if: false(pre-commit, python-lint,grpc-proto-build-check, python-unit-tests, unit-tests, benchmarks,
detect-changes, the other e2e-1gpu/4gpu jobs, e2e-vendor, go-unit-tests,
go-bindings-e2e, finish, summarize-benchmarks).
pushtrigger so CI runs on push.Test Plan
CI on this branch should schedule exactly
build-wheel → e2e-2gpu-pd(×3 matrixlegs) on the
2-gpu-h100-rdma-testrunner; all other jobs report as skipped.Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspasses