Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docker/engine.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
COPY scripts/installation/ /tmp/scripts/

# ── final stage: install SMG + conditionally install engine ──────────────────
FROM ${BASE_IMAGE_REF}

Check warning on line 47 in docker/engine.Dockerfile

View workflow job for this annotation

GitHub Actions / build (vllm/vllm-openai:v0.19.0) / build-and-push

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG ${BASE_IMAGE_REF} results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 47 in docker/engine.Dockerfile

View workflow job for this annotation

GitHub Actions / build (lmsysorg/sglang:v0.5.10) / build-and-push

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG ${BASE_IMAGE_REF} results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 47 in docker/engine.Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc10) / build-and-push

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG ${BASE_IMAGE_REF} results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

ARG ENGINE=sglang
ARG BACKEND
Expand All @@ -56,6 +56,16 @@
COPY --from=sources /tmp/smg-src /opt/smg-src
COPY --from=sources /tmp/scripts/ /tmp/scripts/

# NGC TRT-LLM bases (1.3.0rc18) ship a debian-owned PyYAML with no pip RECORD
# file, which pip refuses to uninstall when install-smg.sh resolves smg's
# pyyaml dependency ("uninstall-no-record-file"). Shadow it with a pip-managed
# copy (--ignore-installed leaves the distro files alone); the smg install can
# then upgrade pyyaml normally. Scoped to trtllm so the other engine bases
# keep their exact pip behavior.
RUN if [ "${ENGINE}" = "trtllm" ]; then \
pip install --no-cache-dir --ignore-installed pyyaml; \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using python3 -m pip is more robust than calling pip directly. It ensures that the package is installed using the correct Python 3 interpreter and avoids potential issues where the pip executable is not in the PATH or points to a different Python installation.

      python3 -m pip install --no-cache-dir --ignore-installed pyyaml; \

fi
Comment thread
slin1237 marked this conversation as resolved.
Resolved

RUN bash /tmp/scripts/install-smg.sh /opt/smg-src

RUN case "${ENGINE}" in \
Expand Down
Loading