refactor: strip R6.x audit-process residue from MCP + router comments (C3) - #1374
Conversation
… (C3) Pure comment hygiene on the R6.x-touched surface (crates/mcp/ + model_gateway/src/routers/). Same pattern C2 (#1310) used on crates/protocols/src/. No semantic changes. Rules applied: - KEEP: spec references with line/SDK path, per-field `///` docs, SAFETY/NOTE invariants, design-intent prose. - DROP: `R6.x:` task markers, per-cycle review narrative, "per coordinator" / "flagged for follow-up" references, "Before R6.8 this did X" historical comparisons now that the PR landed. - PRUNE: multi-paragraph doc blocks where one paragraph is signal and the rest is audit narrative. Acceptance: - `grep -rnE "R6\\.[0-9]" crates/mcp/src/ model_gateway/src/` → zero hits. - `grep -rnE "per coordinator|per audit|per follow-up|cycle-?[12]" crates/mcp/src/ model_gateway/src/` → zero hits. - No changes to any declared pub item, field, enum variant, serde attr, function signature/body, or test. - `cargo check -p openai-protocol -p smg-mcp -p smg --lib --tests --benches` green. - `cargo clippy -p openai-protocol -p smg-mcp -p smg --lib --tests --benches -- -D warnings` green. - `cargo fmt --all` clean. Net line delta: -4 lines (pruning often rewrites prose around the cut line). Co-authored-by: Tingting Zhou <zhoutt96@gmail.com> Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThis PR updates comments and documentation across multiple files, removing specific PR/release references (e.g., R6.2, R6.3, R6.4, R6.7, R6.8) and rephrasing explanatory text. No functional logic, control flow, or behavior changes are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Pure comment hygiene across 11 R6.x-touched files in `crates/mcp/` and `model_gateway/src/routers/`. Mirrors C2 (#1310) which did the same for `crates/protocols/src/` after the Wave-1/2 protocol surface additions.
Rules applied
KEEP: spec references citing file/line or SDK path; per-field `///` docs; `SAFETY:` / `NOTE:` invariants; design-intent prose.
DROP: `R6.x:` task markers; per-cycle review narrative; "per coordinator" / "flagged for follow-up" / "per audit" references; "Before R6.8 this did X" historical comparisons now that the PR landed.
PRUNE: multi-paragraph doc blocks where one paragraph is signal and the rest is audit narrative.
Acceptance
```
$ grep -rnE 'R6.[0-9]' crates/mcp/src/ model_gateway/src/
(no output)
$ grep -rnE 'per coordinator|per audit|per follow-up|cycle-?[12]|Addresses.*bot-review' \
crates/mcp/src/ model_gateway/src/
(no output)
```
Files edited (11)
Net line delta: −4 lines (pruning rewrites some prose around cut lines).
Test plan
Comment-only change. Full cargo build / test / clippy / fmt verified locally.
Summary by CodeRabbit