Skip to content

fix(harmony): shrink BUILTIN_TOOLS to the gpt-oss-native tool set #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slin1237 wants to merge 1 commit into from
Closed

fix(harmony): shrink BUILTIN_TOOLS to the gpt-oss-native tool set #1353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions model_gateway/src/routers/grpc/harmony/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,22 @@ pub(crate) fn convert_harmony_logprobs(proto_logprobs: &ProtoOutputLogProbs) ->
})
}

/// Built-in tools that are added to the system message
/// Built-in tools that are added to the system message.
///
/// Scoped to the hosted tools gpt-oss was trained to emit (per the
/// openai-harmony spec). Advertising a tool here that the model was not
/// trained for — for example `image_generation`, `shell`, `computer`,
/// `apply_patch`, `local_shell` — leads to undefined behavior: the model
/// may hallucinate a malformed tool call, ignore the advertisement, or
/// garble output. Hosted tools outside this set fall through to the
/// custom/function-tool path and, in the future, will be gated
/// per-worker via explicit hosted-tool capability flags + MCP dispatch.
const BUILTIN_TOOLS: &[&str] = &[
"web_search_preview",
"web_search",
"code_interpreter",
"container",
"file_search",
"image_generation",
"shell",
];
Comment thread
slin1237 marked this conversation as resolved.

/// Trait for tool-like objects that can be converted to Harmony ToolDescription
Expand Down
Loading