Skip to content

ci(pr-naming): allow uppercase letters in branch names - #1280

Merged
CatherineSue merged 1 commit into
mainfrom
fix/pr-naming-allow-uppercase
Apr 21, 2026
Merged

CatherineSue merged 1 commit into
mainfrom
fix/pr-naming-allow-uppercase

Conversation

@CatherineSue

@CatherineSue CatherineSue commented Apr 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • The branch-name validator in .github/workflows/pr-naming-check.yml rejects any uppercase letter, auto-closing legitimate PRs such as feat/audit-P4-include-field (see feat(protocols): implement P4 IncludeField web_search_call variants #1271).
  • Widens the two character classes from [a-z0-9] → [a-zA-Z0-9]. Structural rules (must contain a /, must start/end on alphanumeric) are unchanged; the allowed-types list is advisory in the error comment, not enforced by the regex, so this change is purely additive permissiveness.

Test plan

  • Sanity-checked the new regex locally:
    • Passes: feat/audit-P4-include-field, feat/add-auth, fix/null-pointer, changsu/fix-routing, dependabot/cargo/pyo3-0.28.1, feat/CAPS
    • Still rejects: BADSTART (no slash)
  • CI Branch Naming Convention check on this PR is green (branch fix/pr-naming-allow-uppercase is all-lowercase, so it validates under both old and new regex).

Refs: #1271

Summary by CodeRabbit

  • Chores
    • Updated branch naming validation to accept uppercase letters and digits in addition to lowercase letters, providing more flexible branch naming conventions.

The branch-name regex rejected any uppercase, auto-closing legitimate
PRs like feat/audit-P4-include-field (#1271). Widen the character
classes from [a-z0-9] to [a-zA-Z0-9] so mixed-case descriptions and
usernames are accepted; structural rules (must contain '/', must start
with alphanumeric) are unchanged.

Signed-off-by: Chang Su <chang.s.su@oracle.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Apr 21, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The branch-naming validation regex in the GitHub Actions workflow was updated to permit uppercase letters alongside lowercase letters and digits in branch names. The overall validation structure and error-handling flow remain unchanged.

Changes

Cohort / File(s) Summary
Branch Naming Validation
.github/workflows/pr-naming-check.yml
Updated regex pattern from a-z0-9 to a-zA-Z0-9 to allow uppercase letters in branch name segments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • key4ng
  • slin1237
  • XinyueZhang369

Poem

🐰 A rabbit hops with glee,
Branch names now dance wild and free,
Uppercase joins the lowercase crew,
Validation blooms fresh and new! ✨
No more constraints, just open skies,
For every letter in disguise!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: allowing uppercase letters in branch name validation within the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr-naming-allow-uppercase

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Apr 21, 2026
@CatherineSue
CatherineSue merged commit 110b353 into main Apr 21, 2026
14 of 16 checks passed
@CatherineSue
CatherineSue deleted the fix/pr-naming-allow-uppercase branch April 21, 2026 04:29

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal change. The regex update is consistent across all three character classes and correctly allows uppercase letters in branch names. No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant