Repository navigation
ci(pr-naming): allow uppercase letters in branch names - #1280
Conversation
The branch-name regex rejected any uppercase, auto-closing legitimate PRs like feat/audit-P4-include-field (#1271). Widen the character classes from [a-z0-9] to [a-zA-Z0-9] so mixed-case descriptions and usernames are accepted; structural rules (must contain '/', must start with alphanumeric) are unchanged. Signed-off-by: Chang Su <chang.s.su@oracle.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe branch-naming validation regex in the GitHub Actions workflow was updated to permit uppercase letters alongside lowercase letters and digits in branch names. The overall validation structure and error-handling flow remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
.github/workflows/pr-naming-check.ymlrejects any uppercase letter, auto-closing legitimate PRs such asfeat/audit-P4-include-field(see feat(protocols): implement P4 IncludeField web_search_call variants #1271).[a-z0-9]→[a-zA-Z0-9]. Structural rules (must contain a/, must start/end on alphanumeric) are unchanged; the allowed-types list is advisory in the error comment, not enforced by the regex, so this change is purely additive permissiveness.Test plan
feat/audit-P4-include-field,feat/add-auth,fix/null-pointer,changsu/fix-routing,dependabot/cargo/pyo3-0.28.1,feat/CAPSBADSTART(no slash)Branch Naming Conventioncheck on this PR is green (branchfix/pr-naming-allow-uppercaseis all-lowercase, so it validates under both old and new regex).Refs: #1271
Summary by CodeRabbit