Repository navigation
fix(ci): pin vllm<0.19.1 to restore embedding test correctness #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
108bf8b
fix(ci): pin vllm<0.19.1 to restore embedding test correctness
slin1237 e7ac025
fix(ci): also pin transformers<5 to defend against vllm<0.19.1 floating
slin1237 a7db889
fix(ci): drop transformers<5 pin; rely on vllm 0.19.0's own dep range
slin1237 2fc2398
ci: trigger e2e on changes to scripts/ci_install_vllm.sh
slin1237 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure CI stability and consistency with the project's metadata, consider pinning to the exact last-known-good version (vllm==0.19.0). This matches the version cited in the comments and the lower bound defined in grpc_servicer/pyproject.toml. Using an exact pin is generally preferred in CI to ensure reproducibility, especially when a specific version is known to cause regressions. Additionally, since this regression affects core functionality (embedding correctness), this constraint should ideally be reflected in the package metadata (grpc_servicer/pyproject.toml) as well to protect users from installing the broken combination. This approach also adheres to the requirement of using uv pip install for Python package installations in CI scripts for consistency and performance.
References