Skip to content

chore(codeowners): add @zhoug9127 and @zhaowenzi to mcp and data_connector - #1236

Merged
slin1237 merged 1 commit into
mainfrom
chore/codeowners-add-mcp-data-connector-owners
Apr 18, 2026
Merged

chore(codeowners): add @zhoug9127 and @zhaowenzi to mcp and data_connector#1236
slin1237 merged 1 commit into
mainfrom
chore/codeowners-add-mcp-data-connector-owners

Conversation

@slin1237

@slin1237 slin1237 commented Apr 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Problem

/crates/mcp and /crates/data_connector are driven primarily by Daisy and Ziwen, but neither is listed in CODEOWNERS. PRs in these areas miss them as auto-reviewers.

Solution

Add both to the two paths.

Changes

  • /crates/data_connector: add @zhoug9127, @zhaowenzi
  • /crates/mcp: add @zhoug9127, @zhaowenzi

Authorship evidence:

Test Plan

  • .github/CODEOWNERS syntax: two lines edited, each <path> <@owners...> (unchanged format).
  • No Rust / config / protocol / binding files touched → clippy/test/bindings gate not applicable.
  • cargo +nightly fmt --all -- --check — silent success.
  • Pre-commit hooks ran on commit and passed (DCO, no-AI-attribution, branch-name, codespell).
Checklist
  • `cargo +nightly fmt` passes
  • `cargo clippy --all-targets --all-features -- -D warnings` passes (no Rust diff)
  • (Optional) Documentation updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Summary by CodeRabbit

  • Chores
    • Updated code ownership assignments for internal workspace organization.

@slin1237
chore(codeowners): add @zhoug9127 and @zhaowenzi to mcp and data_conn…
2efa4ba 
…ector

Both have been the consistent primary authors of recent PRs in these subsystems:

- @zhoug9127 (Daisy): #1168, #1149, #1065, #1061, #976 — mcp + data_connector
- @zhaowenzi (Ziwen): #1174, #1163, #1123 — mcp

Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
@slin1237
slin1237 requested a review from CatherineSue as a code owner April 18, 2026 00:02
@github-actions github-actions Bot added the ci CI/CD configuration changes label Apr 18, 2026
@coderabbitai

coderabbitai Bot commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fa98e142-002a-4632-9ef4-6044295f7b69

📥 Commits

Reviewing files that changed from the base of the PR and between 215ef8b and 2efa4ba.

📒 Files selected for processing (1)
  • .github/CODEOWNERS
📝 Walkthrough

Walkthrough

This pull request updates the GitHub CODEOWNERS file to designate additional code owners for the /crates/data_connector and /crates/mcp workspace crates by adding two new team members.

Changes

Cohort / File(s) Summary
CODEOWNERS Configuration
.github/CODEOWNERS		 Added two new code owners to /crates/data_connector and /crates/mcp crates for improved code ownership and review coverage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • CatherineSue

Poem

🐰 Two new shepherds join the crate,
With careful hands to code orchestrate,
The CODEOWNERS file now shines so bright,
Guiding reviews toward the light! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically describes the main change: adding two code owners to the CODEOWNERS file for two workspace crates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/codeowners-add-mcp-data-connector-owners

Comment @coderabbitai help to get the list of available commands and usage tips.

claude[bot]
claude Bot approved these changes Apr 18, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward CODEOWNERS update adding new reviewers to /crates/data_connector and /crates/mcp. No issues found.

@slin1237
slin1237 merged commit 82a3fb1 into main Apr 18, 2026
16 checks passed
@slin1237
slin1237 deleted the chore/codeowners-add-mcp-data-connector-owners branch April 18, 2026 00:04
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file to add @zhoug9127 and @zhaowenzi as owners for the data_connector and mcp crates. I have no feedback to provide.

@coderabbitai coderabbitai Bot mentioned this pull request Jun 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@claude claude[bot] claude[bot] approved these changes
@CatherineSue CatherineSue Awaiting requested review from CatherineSue CatherineSue is a code owner
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci CI/CD configuration changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slin1237