Repository navigation
docs: add a multimodal pipeline concept page - #44
Merged
Merged
Conversation
Explain how images and video flow through SMG v1.11.0 on gRPC workers: router-side preprocessing vs worker-side processing on vLLM and the Redis sidecar (smg-project/smg#2399, #2400, #2401, #2625, #2626), supported model families and limits, video sampling (#2579, #2584), in-flight budget and errors (#2381, #2585), tensor transport, and the ZMQ, PD and EPD paths (#2539, #2627, #2640). Add the page to the Architecture nav and index. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Your 65 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Comment |
This was referenced Sep 24, 2026
- vLLM worker examples: vLLM's gRPC launcher does not pass the --mm-* flags to the servicer, so set SMG_VLLM_MM_* variables instead. - SMG reads the mm_processor label at worker registration, so a sidecar started after the worker does not switch auto to worker-side processing. - An oversized sidecar result fails with a 400 whose message includes media_too_large (the limit is at-or-above); the sidecar queue cap fails fast once that many jobs are queued. - PD router path: SGLang decode gets no media data, vLLM n>1 decode keeps the full payload, and the cache salt applies only without grid tensors. - In-flight budget: a full waiting queue also returns 429 immediately. - SMG_VIDEO_PROCESS_TIMEOUT_SECS also bounds OpenCV decodes. - Example uses smg launch instead of bare smg. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multimodal was the largest area of change in v1.11.0, about 60 smg commits, and the site had no multimodal page. Only a short tensor-transport table in the configuration reference covered it. This adds a concept page on how images and video flow through SMG with gRPC workers, and where noted with the direct ZMQ backends.
Changes
concepts/architecture/multimodal.md("Multimodal Pipeline")--mm-processing auto|router|workerand the media-reference contract for vLLM gRPC workers (feat(vllm-grpc): media_refs wire contract and worker-side media processing smg#2399, #2400).opencv-videofeature.fpsandmax_long_side_pixelextensions.image_urlexample.The worker spec has
multimodal_tensor_transportandmultimodal_shm_min_bytesfields, and the transport code reads them. In v1.11.0, though, worker registration never copies them onto the worker. The page says so instead of presenting them as working overrides; #43 has the details.Verification
v1.11.0(3be823a7):routers/grpc/multimodal/*(plan, refs, settings, inflight, transport, assemble, process, pixel cache),crates/multimodal(registry, media, tracker, processors),grpc_servicer/smg_grpc_servicer/vllm/*(mm_processor, mm_sidecar, servicer), andobservability/metrics.rs.pnpm lint,pnpm check(0 errors), andpnpm buildpass.zmq-workers.md,configuration.md#multimodal-configuration, andadmin.md#worker-spec(docs(api): document the full worker spec for the worker management API #43).wrangler pages dev.This is one of a series of docs PRs that bring the site up to smg v1.11.0, one per area.
🤖 Generated with Claude Code