This repository has been archived by the owner on Aug 14, 2018. It is now read-only.
Added metadata preset for Sign4 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcylabs - Can you tell us more about what you're trying to accomplish? |
|
@mdwhatcott - I try using Sign4 behind CloudFlare, where the guess logic of service and region can't work. With this PR you can hard-pass a preset of metadata that could not be guessed |
mdwhatcott
reviewed
Jun 29, 2017
| Service string | ||
| } | ||
|
|
||
| func (m *Metadata) SetAlgorithm(value string){ |
There was a problem hiding this comment.
I see that these setter functions prevent any original value from being overwritten--what's the need for that constraint?
There was a problem hiding this comment.
I'm wondering why we need setter functions at...
|
Due to #49 I am closing all pull requests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.