Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add masquerade binding method #26

Merged

Conversation

scuzhanglei
Copy link
Contributor

Signed-off-by: zhanglei [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #26 (36cfdd2) into main (d146dc5) will increase coverage by 4.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   31.66%   35.72%   +4.05%     
==========================================
  Files           3        3              
  Lines         938      949      +11     
==========================================
+ Hits          297      339      +42     
+ Misses        594      560      -34     
- Partials       47       50       +3     
Impacted Files Coverage Δ
pkg/controller/vm_webhook.go 42.61% <100.00%> (+8.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scuzhanglei scuzhanglei requested a review from fengye87 August 16, 2022 07:53
Copy link
Contributor

@fengye87 fengye87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scuzhanglei scuzhanglei merged commit 6a9aeed into smartxworks:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants